Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grut699-vxworks6 cfe_psp_timer.c per white box unit testing results #40

Closed
skliper opened this issue Sep 25, 2019 · 6 comments
Closed
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@skliper
Copy link
Contributor

skliper commented Sep 25, 2019

During white box testing the following issue was identified with the grut699-vxworks6 version of cfe_psp_timer.c

  • CFE_PSP_Get_Timebase - possible divide by zero in the calculation:

lower /= sysTimestampFreq() / 1000000UL

if sysTimestampFreq() returns a number less than 1000000UL.

Issue identified during #14 white box testing commit: [changeset:eade737]

@skliper skliper self-assigned this Sep 25, 2019
@skliper skliper added the bug Something isn't working label Sep 25, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Imported from trac issue 36. Created by dasp on 2015-08-13T19:13:00, last modified: 2019-05-06T11:51:35

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by sduran on 2015-08-17 11:50:52:

If sysTimestampFreq() returns a value less then 1000000UL, it would mean the processor's system clock is less than 1MHz - The SPARC runs at 25MHz and higher, 75MHz on our test board, >=100MHz for Orion. Since this PSP is only for the ut699 SPARC Leon3, I think it is safe to say that we will not be using this code on a processor running less than 1MHz.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by abrown4 on 2015-09-01 20:16:18:

In #15 Steve made a change to cfe_psp_timer.c that removes this division entirely, commit: [changeset:db39700], on Trac #14 branch.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by abrown4 on 2015-09-01 20:17:18:

Unit test needs to be updated to remove the failing placeholder test.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by abrown4 on 2015-09-02 12:14:06:

commit: [changeset:9976a8c] PSP Trac #14 & #15 Updated PSP timer white-box for commit db39700 (cfe_psp_timer.c).

This ticket's intent is completed.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by jhageman on 2019-05-06 11:51:35:

Specific to non-community PSP so closing as invalid. Note changes were merged to techdev-pc-linux-uei, techdev-sp0-vxworks6.9 branches (but not techdev-ut699 for some reason). Not in framework release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant