Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Test_MSG_PrintMsg in favor of UT_DisplayPkt #1030

Closed
skliper opened this issue Nov 24, 2020 · 1 comment · Fixed by #1046 or #1047
Closed

Remove Test_MSG_PrintMsg in favor of UT_DisplayPkt #1030

skliper opened this issue Nov 24, 2020 · 1 comment · Fixed by #1046 or #1047
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Nov 24, 2020

Is your feature request related to a problem? Please describe.
Test_MSG_PrintMsg was added with MSG module, but duplicates what UT_DisplayPkt already did. No need for both.

Describe the solution you'd like
Replace Test_MSG_PrintMsg with UT_DisplayPkt and remove.

Describe alternatives you've considered
None.

Additional context
None.

Requester Info
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Nov 24, 2020

Also should remove Test_MSG_Sum, this was just a lazy way to check a message that is no longer used anyways (didn't end up working well when default values that may be overwritten based on implementation are involved). Basically test_msg_utils.[ch] can go away.

@zanzaben zanzaben self-assigned this Dec 7, 2020
zanzaben added a commit to zanzaben/cFE that referenced this issue Dec 9, 2020
zanzaben added a commit to zanzaben/cFE that referenced this issue Dec 14, 2020
zanzaben added a commit to zanzaben/cFE that referenced this issue Dec 14, 2020
@astrogeco astrogeco added bug CCB:Approved Indicates code review and approval by community CCB unit-test and removed CCB:Approved Indicates code review and approval by community CCB labels Dec 18, 2020
@astrogeco astrogeco added this to the 7.0.0 milestone Dec 18, 2020
astrogeco added a commit that referenced this issue Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants