Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define and apply naming standard for event ID definitions #1532

Open
skliper opened this issue May 17, 2021 · 1 comment
Open

Define and apply naming standard for event ID definitions #1532

skliper opened this issue May 17, 2021 · 1 comment

Comments

@skliper
Copy link
Contributor

skliper commented May 17, 2021

Is your feature request related to a problem? Please describe.
Some services include the error type as part of the name of the EID/EventID/Event id, others don't:

#define CFE_TBL_INIT_INF_EID 1

#define CFE_TIME_INIT_EID 1 /* start up message "informational" */

Describe the solution you'd like
Define and apply standard naming pattern. Suggest append either _INFO_EID, DEBUG_EID, ERR_EID, or CRIT_EID to the name.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

@thnkslprpt
Copy link
Contributor

Basically all of the cFS components/apps use abbreviations for the INF & DBG types, so I suggest sticking with that format:
_INF_EID
_DBG_EID
_ERR_EID
_CRIT_EID (...if CRITICAL is still actually used. Seems like most have been labelled as ERR rather than having a specific category for CRITICAL errors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants