You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Some services include the error type as part of the name of the EID/EventID/Event id, others don't:
#defineCFE_TIME_INIT_EID 1 /* start up message "informational" */
Describe the solution you'd like
Define and apply standard naming pattern. Suggest append either _INFO_EID, DEBUG_EID, ERR_EID, or CRIT_EID to the name.
Describe alternatives you've considered
None
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
Basically all of the cFS components/apps use abbreviations for the INF & DBG types, so I suggest sticking with that format:
_INF_EID
_DBG_EID
_ERR_EID
_CRIT_EID (...if CRITICAL is still actually used. Seems like most have been labelled as ERR rather than having a specific category for CRITICAL errors)
Is your feature request related to a problem? Please describe.
Some services include the error type as part of the name of the EID/EventID/Event id, others don't:
cFE/modules/tbl/fsw/inc/cfe_tbl_events.h
Line 68 in 84ba9a9
cFE/modules/time/fsw/inc/cfe_time_events.h
Line 60 in 84ba9a9
Describe the solution you'd like
Define and apply standard naming pattern. Suggest append either _INFO_EID, DEBUG_EID, ERR_EID, or CRIT_EID to the name.
Describe alternatives you've considered
None
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: