Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfe_*_verify.h files aren't included anywhere, so error checks aren't being applied #1548

Closed
skliper opened this issue May 18, 2021 · 0 comments · Fixed by #1557 or #1584
Closed

cfe_*_verify.h files aren't included anywhere, so error checks aren't being applied #1548

skliper opened this issue May 18, 2021 · 0 comments · Fixed by #1557 or #1584
Assignees
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented May 18, 2021

Describe the bug

$ find ./ -name "*_verify.h"
./modules/sb/fsw/src/cfe_sb_verify.h
./modules/time/fsw/src/cfe_time_verify.h
./modules/tbl/fsw/src/cfe_tbl_verify.h
./modules/evs/fsw/src/cfe_evs_verify.h
./modules/es/fsw/src/cfe_es_verify.h
$ grep -r "_verify.h" *
$

To Reproduce
Can also test by providing an invalid parameter. I set:
#define CFE_PLATFORM_ES_APP_SCAN_RATE 1000000
which should have triggered:

#elif CFE_PLATFORM_ES_APP_SCAN_RATE > 20000
#error CFE_PLATFORM_ES_APP_SCAN_RATE cannot be greater than 20 seconds!
#endif

Expected behavior
Verifications should be performed

Code snips
NA

System observed on:

  • Hardware: Docker on laptop
  • OS: Ubuntu 18.04
  • Versions: Bundle main

Additional context
#1547

Reporter Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant