Fix #2243, CFE_TBL_FILEDEF does not need static #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-2243-filedef-notstatic
branch
from
c97cd62
to
caa00de
Compare
Remove the "static" qualification from the TBL file def objects, it is not needed, and works fine without any special sauce here. This also adds extended documentation to all of the FILEDEF object members to explain naming conventions and recommended practice.
jphickey
force-pushed
the
fix-2243-filedef-notstatic
branch
from
caa00de
to
0be50e9
Compare
dzbaker
added
the
CCB:Approved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Remove the "static" qualification from the TBL file def objects, it is not needed, and works fine without any special sauce here.
Testing performed
Build and run all tests
Run CFE with apps and confirm tables load normally
Expected behavior changes
None
System(s) tested on
Debian
Additional context
Tables do not need to be declared static because they are just used with a table tool like
elf2cfetbl- they are never linked with other table definition files by the C linker, so thestaticdesignation is not needed. On the other hand, it may cause issues with alternative table creation methods because it hides the symbol from e.g.dlsym(). Furthermore, it necessitates use of a compiler-specific extension flag to avoid a warning, which is against coding standards.Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.