Fix #2478, Add missing default
/break
to switch
statements
#2479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe 2the contribution
switch
statements in cFE are missing adefault
and/orbreak
#2478switch
blocks that were missingdefault
and/orbreak
statements have been correctedTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Note: Most of the added
default
case lines are not tested (impossible to test given that all cases are handled explicitly) so the number of missed lines has grown larger.Expected behavior changes
Effectively no change to current behavior.
Ensuring switch statements are well-formed is good defensive coding for future code changes and improves consistency across cFE.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt