You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Setting OMIT_DEPRECATED=true from the make line should omit all deprecated elements. With the current pattern, submodules have similar prefixed defines like CFE_OMIT_DEPRECATED and the expectation is at the global/mission config level OMIT_DEPRECATED needs to set all the submodule defines. Users don't necessarily keep up with the additions, nor does the cFE example:
set(MISSION_RESOURCEID_MODE "STRICT") # more type safe, but less backward compatible
else()
Note across cFS there's at minimum a CFE_OMIT_DEPRECATED as well as a few app specific ones like SC_OMIT_DEPRECATED.
Describe the solution you'd like
OMIT_DEPRECATED should omit all deprecated elements in a build. Consider at the submodule an or of the generic or submodule specific defines.
Describe alternatives you've considered
Submodule could define the submodule specific ones if the generic one is defined, but if it's a step away from where it's used that could also fall behind (like cFE did).
Additional context
Actual problem that was addressed in nasa/sch_lab#163, where sch_lab was using a deprecated cFE define since it wasn't being excluded correctly in the build CI when using OMIT_DEPRECATED.
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Setting
OMIT_DEPRECATED=true
from the make line should omit all deprecated elements. With the current pattern, submodules have similar prefixed defines likeCFE_OMIT_DEPRECATED
and the expectation is at the global/mission config levelOMIT_DEPRECATED
needs to set all the submodule defines. Users don't necessarily keep up with the additions, nor does the cFE example:cFE/cmake/sample_defs/global_build_options.cmake
Lines 20 to 24 in 7f5ebcd
Note across cFS there's at minimum a CFE_OMIT_DEPRECATED as well as a few app specific ones like SC_OMIT_DEPRECATED.
Describe the solution you'd like
OMIT_DEPRECATED should omit all deprecated elements in a build. Consider at the submodule an
or
of the generic or submodule specific defines.Describe alternatives you've considered
Submodule could define the submodule specific ones if the generic one is defined, but if it's a step away from where it's used that could also fall behind (like cFE did).
Additional context
Actual problem that was addressed in nasa/sch_lab#163, where sch_lab was using a deprecated cFE define since it wasn't being excluded correctly in the build CI when using
OMIT_DEPRECATED
.Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: