Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2561, send CMake message to stdout instead of stderr #2525

Merged
merged 1 commit into from
May 21, 2024

Conversation

Codym48
Copy link
Contributor

@Codym48 Codym48 commented Mar 8, 2024

Checklist (Please check before submitting)

Describe the contribution
Fix #2561.

While executing the drac0-rc5 training exercises, I noticed on the first make prep call that the following message is printed to stderr

NOTE: Selected /home/cmartin/code/cFS/sample_defs/cpu1_cfe_es_startup.scr as source for cfe_es_startup.scr on cpu1

This seems like an informational message that would be more appropriate for stdout than stderr, so I added the STATUS keyword to the cmake message call.

Testing performed
Before change

make prep > stdout.log # observe NOTE printed to screen despite passing stdout to file

After change

rm -rf build
make prep > stdout.log # observe nothing printed to screen 🎉

Expected behavior changes

  • API Change: None
  • Behavior Change: One message that used to go to stderr now goes to stdout

System(s) tested on

  • Hardware: PC
  • OS: Ubuntu 22.04
  • Versions: draco-rc5

Additional context
This is a bit of a trial balloon to feel out the cFS contribution process. I won't be offended if you close this Pull Request with no action. Thank you for your hard work on this product and its outstanding documentation!

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Cody Martin (Personal contributor)

@Codym48 Codym48 changed the title Send CMake message to stdout instead of stderr Fix #2561, send CMake message to stdout instead of stderr May 11, 2024
@Codym48 Codym48 marked this pull request as ready for review May 11, 2024 18:07
@Codym48
Copy link
Contributor Author

Codym48 commented May 11, 2024

FYI @jphickey as the last developer that touched this line

@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label May 16, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request May 21, 2024
*Combines:*

cFE equuleus-rc1+dev137
osal equuleus-rc1+dev66
PSP equuleus-rc1+dev42
to_lab equuleus-rc1+dev56

**Includes:**

*cFS*
- #751
- #762

*cFE*
- nasa/cFE#2537
- nasa/cFE#2525

*osal*
- nasa/osal#1460

*PSP*
- nasa/PSP#430

*to_lab*
- nasa/to_lab#198

Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Cody Martin <Codym48@users.noreply.github.com>
@dzbaker dzbaker merged commit 2032843 into nasa:main May 21, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request May 21, 2024
*Combines:*

cFE equuleus-rc1+dev137
osal equuleus-rc1+dev66
PSP equuleus-rc1+dev42
to_lab equuleus-rc1+dev56

**Includes:**

*cFS*
- #751
- #762

*cFE*
- nasa/cFE#2537
- nasa/cFE#2525

*osal*
- nasa/osal#1460

*PSP*
- nasa/PSP#430

*to_lab*
- nasa/to_lab#198

Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Cody Martin <Codym48@users.noreply.github.com>
Co-authored by: Dan Knutsen <dmknutsen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send informational CMake message(s) to stdout instead of stderr
2 participants