Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_PLATFORM_SB_MAX_PIPE_DEPTH reporting and use misleading in relation to OS_MAX_QUEUE_DEPTH #996

Closed
skliper opened this issue Nov 3, 2020 · 0 comments · Fixed by #1111 or #1150
Closed

CFE_PLATFORM_SB_MAX_PIPE_DEPTH reporting and use misleading in relation to OS_MAX_QUEUE_DEPTH #996

skliper opened this issue Nov 3, 2020 · 0 comments · Fixed by #1111 or #1150
Labels
bug
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Nov 3, 2020

Is your feature request related to a problem? Please describe.
CFE_PLATFORM_SB_MAX_PIPE_DEPTH is reported in CFE_SB.StatTlmMsg.Payload.MaxPipeDepthAllowed, which is not true if it's > OS_MAX_QUEUE_DEPTH.

Describe the solution you'd like
Maybe remove as a CFE platform config? It doesn't size arrays or anything, so it seems arbitrary at the cFE level. OSAL checks vs OS_MAX_QUEUE_DEPTH.

Describe alternatives you've considered
Verify < or = OS_MAX_QUEUE_DEPTH?

Additional context
See nasa/osal#235

Requester Info
Jacob Hageman - NASA/GSFC
skliper added a commit to skliper/cFE that referenced this issue Jan 21, 2021
@skliper
Fix nasa#996, Remove CFE_PLATFORM_SB_MAX_PIPE_DEPTH in favor of OS_QU…
8e3a5ff 
…EUE_MAX_DEPTH
@skliper skliper mentioned this issue Jan 21, 2021
Merged
skliper added a commit to skliper/cFE that referenced this issue Jan 27, 2021
@skliper
Fix nasa#996, Remove CFE_PLATFORM_SB_MAX_PIPE_DEPTH in favor of OS_QU…
bd051ff 
…EUE_MAX_DEPTH
@astrogeco astrogeco added this to the 7.0.0 milestone Feb 3, 2021
astrogeco added a commit that referenced this issue Feb 3, 2021
@astrogeco
Merge pull request #1111 from skliper/fix996-max_queue_depth
64aeec0 
Fix #996, Remove CFE_PLATFORM_SB_MAX_PIPE_DEPTH in favor of OS_QUEUE_MAX_DEPTH
@astrogeco astrogeco mentioned this issue Feb 15, 2021
Merged
@astrogeco astrogeco added bug and removed enhancement labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco