Fix #662, Removes error on format style differences #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
that referenced
this pull request
Jun 1, 2023
*Combines:* cFE v7.0.0-rc4+dev334 osal v6.0.0-rc4+dev217 **Includes:** *cFS* - #680 - #676 *cFE* - nasa/cFE#2350 - nasa/cFE#2354 - nasa/cFE#2355 - nasa/cFE#2366 - nasa/cFE#2364 - nasa/cFE#2356 - nasa/cFE#2361 *osal* - nasa/osal#1393 Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Chris Knight <cdknightnasa@users.noreply.github.com>
dzbaker
added a commit
that referenced
this pull request
Jun 1, 2023
*Combines:* cFE v7.0.0-rc4+dev334 osal v6.0.0-rc4+dev217 **Includes:** *cFS* - #680 - #676 *cFE* - nasa/cFE#2350 - nasa/cFE#2354 - nasa/cFE#2355 - nasa/cFE#2366 - nasa/cFE#2364 - nasa/cFE#2356 - nasa/cFE#2361 *osal* - nasa/osal#1393 Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Chris Knight <cdknightnasa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
Observed that error does not happen when format-check is called and there is a claang-format-10 style difference.
Expected behavior changes
No error on style differences
System(s) tested on
Additional context
N/A
Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage