Fix #382, Reuse CodeQL, Static Analysis, and Format Check #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArielSAdamsNASA
added
CCB:Ready
ArielSAdamsNASA
force-pushed
the
fix-382-reuse-workflows
branch
2 times, most recently
from
9a6d01c
to
48cc337
Compare
ArielSAdamsNASA
removed
the
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Invalid
Testing performed
Tested on forked repos.
OSAL Static Analysis Reuse: https://github.com/ArielSAdamsNASA/osal/actions/runs/1387270204 - runs bundle and strict osal
cFS Static Analysis Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390418206
OSAL CodeQL Reuse cFE Build: https://github.com/ArielSAdamsNASA/osal/runs/4023159610?check_suite_focus=true
OSAL CodeQL Reuse OSAL Default: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702434
cFS CodeQL Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390777421
OSAL Format Check Reuse: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702433
cFS Format Check: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390865379
Expected behavior changes
cFS will hold the workflows for CodeQL, Static Analysis, and Format Check. These workflows will be called by all subrepos to use. cFS has to call on CodeQL and Static Analysis for the workflows to work. Format check does not need to be reused in cFS since there are no inputs.
To explain the new workflows, a diagram has been added to the README.md file. The PR does not show the image in the README.md file, but the same code and image works in the forked repo: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/blob/Rule1/.github/workflows/README.md
Additional context
The workflows calling the original actions will not work until it is integrated in main because of this code.
uses: nasa/cFS/.github/workflows/static-analysis.yml@mainDocumentation: https://docs.github.com/en/actions/learn-github-actions/reusing-workflows
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal