-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #382, Reuse CodeQL, Static Analysis, Format Check #386
Conversation
be8ade6
to
506d0a5
Compare
506d0a5
to
d47752f
Compare
Change Static Analysis workflow to remove inputs.module. Add matrix back. Use cppcheck code for strict modules, but change the directory using an input. Tested: |
d47752f
to
a5c3097
Compare
a5c3097
to
8f11535
Compare
jobs: | ||
static-analysis: | ||
name: Static Analysis | ||
uses: nasa/cFS/.github/workflows/static-analysis.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we probably want to add in the full directory list for the submodules to do the strict static analysis on so it replicates the old functionality. Can be just one big list now. Eventually the idea would be to abstract the list out at the cFS level and get it from each repo, but for now hard coding is fine.
8f11535
to
387df8d
Compare
CCB:2021-11-03 APPROVED
|
Fix nasa#381, Reuse CodeQL, Static Analysis, Format Check
Fix nasa#381, Reuse CodeQL, Static Analysis, Format Check
f7b8cbb
to
d686e62
Compare
Fix nasa#381, Reuse CodeQL, Static Analysis, Format Check
Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
d686e62
to
7e31d11
Compare
Fix nasa#382, Reuse CodeQL, Static Analysis, Format Check
Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
7e31d11
to
cff81c0
Compare
Checklist (Please check before submitting)
Describe the contribution
Fixes #382
Testing performed
Tested on forked repos.
OSAL Static Analysis Reuse: https://github.com/ArielSAdamsNASA/osal/actions/runs/1387270204 - runs bundle and strict osal
cFS Static Analysis Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390418206
OSAL CodeQL Reuse cFE Build: https://github.com/ArielSAdamsNASA/osal/runs/4023159610?check_suite_focus=true
OSAL CodeQL Reuse OSAL Default: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702434
cFS CodeQL Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390777421
OSAL Format Check Reuse: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702433
cFS Format Check: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390865379
Expected behavior changes
cFS will hold the workflows for CodeQL, Static Analysis, and Format Check. These workflows will be called by all subrepos to use. cFS has to call on CodeQL and Static Analysis for the workflows to work. Format check does not need to be reused in cFS since there are no inputs.
To explain the new workflows, a diagram has been added to the README.md file. The PR does not show the image in the README.md file, but the same code and image works in the forked repo: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/blob/fix-382-reuse-workflows/.github/workflows/README.md
Additional context
The workflows calling the original actions will not work until it is integrated in main because of this code.
uses: nasa/cFS/.github/workflows/static-analysis.yml@main
Documentation: https://docs.github.com/en/actions/learn-github-actions/reusing-workflows
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal