Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #488, Pad msg headers to 64 bit #1077

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 7, 2021

Describe the contribution
Fix #488 - pads headers to 64-bit so that CFE_SB_GetUserData will work for message structures with elements up to 64 bit

Testing performed
Added #903 (to catch errors from CFE_SB_GetUserData), built unit tests for both primary only and primary + extended headers, passed.

Expected behavior changes
For primary only config - telemetry header required to 64 bit boundary (affects all receivers)
For primary + extended config - command header required padding to 64 bit boundary (affects all senders)

System(s) tested on

Additional context
Will require updates in cFS-GroundSystem, both cmdUtil, and cmd/tlm from the GUI

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@astrogeco
Copy link
Contributor

astrogeco commented Jan 13, 2021

CCB:2021-01-13 APPROVED

BREAKS everyone's command and telemetry.

Does not violate CCSDS since this goes in the secondary header.

Gets rid of implicit compiler padding.

See nasa/cFS-GroundSystem#148 and nasa/cFS-GroundSystem#145

@astrogeco astrogeco added CCB:2021-01-13 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 13, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate January 25, 2021 02:38
@astrogeco astrogeco merged commit a68947e into nasa:integration-candidate Jan 25, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 25, 2021
@skliper skliper deleted the fix488-header_alignment branch February 1, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cFE Tlm Packet 64-bit alignment issue
2 participants