Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1692, Add misc time api functional test #1767

Conversation

nmullane
Copy link
Contributor

@nmullane nmullane commented Aug 5, 2021

Describe the contribution
Fixes #1692

Testing performed
Steps taken to test the contribution:

  1. Build and run cfe functional tests

Expected behavior changes

  • No impact to behavior

System(s) tested on

  • Hardware: PC
  • OS: Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Niall Mullane - GSFC 582 Intern

@nmullane nmullane force-pushed the fix1692-misc-time-functional-tests branch from 677e91e to 2671a31 Compare August 5, 2021 17:43
@nmullane
Copy link
Contributor Author

nmullane commented Aug 5, 2021

This PR depends on nasa/osal#1125

@nmullane
Copy link
Contributor Author

nmullane commented Aug 9, 2021

I believe this should be passing now. Is there a way to rerun the github action checks?

@astrogeco astrogeco changed the base branch from main to integration-candidate August 9, 2021 21:28
@astrogeco astrogeco requested a review from zanzaben August 9, 2021 21:29
@astrogeco
Copy link
Contributor

astrogeco commented Aug 9, 2021

@nmullane can you rebase to fix conflicts? That will also re-run the tests. But if you ever want to re run them manually there's a button for that on the "checks" tab

Screen Shot 2021-08-09 at 5 30 26 PM

@nmullane nmullane force-pushed the fix1692-misc-time-functional-tests branch from 2671a31 to e6979cf Compare August 10, 2021 13:10
@nmullane
Copy link
Contributor Author

@nmullane can you rebase to fix conflicts? That will also re-run the tests. But if you ever want to re run them manually there's a button for that on the "checks" tab

Screen Shot 2021-08-09 at 5 30 26 PM

Rebased 👍

Also it looks like I don't have the ability to rerun checks.

@astrogeco astrogeco added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) and removed conflicts labels Aug 10, 2021
@astrogeco astrogeco merged commit f8ceda1 into nasa:integration-candidate Aug 10, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 10, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 11, 2021
**Combines**

- nasa/cFE#1772, v6.8.0-rc1+dev844
- nasa/osal#1127, v5.1.0-rc1+dev590

**Includes**

*cFE*

- nasa/cFE#1737, Move global count into test global struct.
- nasa/cFE#1722, Add ES application control API functional tests
- nasa/cFE#1743, Update coverage test to use UtAssert macros
- nasa/cFE#1734, Add table api functional tests
- nasa/cFE#1753, Add Generic Counter API test
- nasa/cFE#1766, finish ES misc API functional test
- nasa/cFE#1764, last char truncated in coverage log output
- nasa/cFE#1728, Mistakes in some copyright headers
- nasa/cFE#1767, Add misc time api functional test cFE
- nasa/cFE#1749, Add Functional Test for EVS Reset Filters API
- nasa/cFE#1781, RTEMS CFE_FT_Global build failure
- nasa/cFE#1796, replace VOIDCALL assert macro

*osal*

- nasa/osal#1117, Add absolute branch coverage check
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 11, 2021
**Combines**

- nasa/cFE#1772, v6.8.0-rc1+dev844
- nasa/osal#1127, v5.1.0-rc1+dev590

**Includes**

*cFE*

- nasa/cFE#1737, Move global count into test global struct.
- nasa/cFE#1722, Add ES application control API functional tests
- nasa/cFE#1743, Update coverage test to use UtAssert macros
- nasa/cFE#1734, Add table api functional tests
- nasa/cFE#1753, Add Generic Counter API test
- nasa/cFE#1766, finish ES misc API functional test
- nasa/cFE#1764, last char truncated in coverage log output
- nasa/cFE#1728, Mistakes in some copyright headers
- nasa/cFE#1767, Add misc time api functional test cFE
- nasa/cFE#1749, Add Functional Test for EVS Reset Filters API
- nasa/cFE#1781, RTEMS CFE_FT_Global build failure
- nasa/cFE#1796, replace VOIDCALL assert macro

*osal*

- nasa/osal#1117, Add absolute branch coverage check

Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com>
Co-authored-by: Niall Mullane <nmullane@users.noreply.github.com>
Co-authored-by: Paul <pavll@users.noreply.github.com>
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 11, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functional tests for cFE Miscellaneous Time APIs
3 participants