Fix #1825, #1826, #1829, #1830, SB test improvements #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the CFE_SB_PEND_FOREVER flag on a few of the calls to CFE_SB_ReceiveBuffer to confirm that this works as expected. Previously only CFE_SB_POLL and a nonzero timeout were used. Note this can only be used when it is known/expected that the message queue is not empty. If there is any possiblility that the queue is empty, then this cannot be used or else the test may block. This also means that if the test fails, it may fail by blocking and never finishing the test rather than an actual FAIL testcase.
Add test cases to confirm that when multiple pipes are subscribed to the same message ID, that: 1. Broadcasting (transmit side) is successful even if some of the pipes are not deliverable. 2. MsgLimit (from subscription) and PipeDepth (from pipe create) are honored. 3. If some pipes are undeliverable for any reason, delivery to open pipes is not affected.
Extends the broadcast test case to cover unsubscription of a single pipe ID. Confirms that other pipes/subscriptions are not affected, and that the limits initially enforced on those original subscriptions still apply.
Add test cases to the zero copy sequence to confirm proper override and/or increment of the sequence count.
jphickey
added
the
CCB:Ready
astrogeco
removed
the
CCB:Ready
zanzaben
approved these changes
Aug 25, 2021
astrogeco
added
the
CCB:Approved
|
CCB:2021-08-25 APPROVED |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 27, 2021
nasa/cFE#1876, SB test improvements nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag nasa/cFE#1881, Improve EVS code coverage
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 27, 2021
nasa/cFE#1876, SB test improvements nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag nasa/cFE#1881, Improve EVS code coverage
This was referenced Aug 27, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2021
**Combines** nasa/cFE#1885, v6.8.0-rc1+dev980 nasa/osal#1138, v5.1.0-rc1+dev598 nasa/cFS-GroundSystem#195, v2.2.0-rc1+dev63 **Includes** *cFE* nasa/cFE#1870, Add SB API test cases nasa/cFE#1869, Add ES API test cases nasa/cFE#1872, Add TBL API test cases nasa/cFE#1871, Add FS API test cases nasa/cFE#1860, Add Time Clock Test nasa/cFE#1862, EVS coverage test nasa/cFE#1876, SB test improvements nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag nasa/cFE#1881, Improve EVS code coverage nasa/cFE#1877, add call to CFE_ES_ExitChildTask nasa/cFE#1902, Incorrect OSAL Format in Users Guide Reference nasa/cFE#1884, Improve FS coverage nasa/cFE, Improve MSG branch coverage nasa/cFE#1891, Improve resource ID branch coverage nasa/cFE#1894, Improve SBR branch coverage nasa/cFE#1896, Fix #1895, Improve TIME branch coverage nasa/cFE#1904, Improve TBL code coverage nasa/cFE#1864, Support custom PSP directory nasa/cFE#1913, Update time tests to use bitmask check macros nasa/cFE#1923, remove extra word in comment *osal* nasa/osal#1136, add bitmask assert macros *cFS-GroundSystem* nasa/cFS-GroundSystem#190, Fix #189, Virtualenv and Pipenv .gitignore support nasa/cFS-GroundSystem#194, Fix doc, comment, and message typos Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com> Co-authored-by: Avi <thnkslprpt@users.noreply.github.com> Co-authored-by: Paul <pavll@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
A set of additional test cases to improve requirements coverage of the SB functional test.
Fixes #1825 - Adds unsubscribe of single pipe ID, confirms other subscriptions not changed
Fixes #1826 - Confirms that MsgLimit and PipeDepth are both honored and that delivery to other (open) pipes is not affected when some pipes have reached delivery limits
Fixes #1829 - Adds use of CFE_SB_PEND_FOREVER in some cases
Fixes #1830 - Adds a sequence number validation to the Zero copy test.
Testing performed
Build and sanity check CFE, run all functional tests
Expected behavior changes
Functional test covers requirements as indicated in linked issues
System(s) tested on
Ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.