Fix #1512, Add Coding Standard Rules in CodeQL #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT - obsolete comment, PR was reopened |
ArielSAdamsNASA
added
the
CCB:Ready
|
CCB: Approved, consider moving configuration to cFS |
skliper
added
the
CCB:Approved
|
Removed configuration files and used cFS configuration files instead. CodeQL workflow is successful. |
astrogeco
removed
the
CCB:Ready
astrogeco
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1512
Added the duplicate jobs action to avoid duplicate jobs from running. Added a separate job for coding standard queries. Created two configuration files, one for default queries and security queries and another for jpl rules.
Testing performed
Testing done on forked repository, ArielSAdamsNASA/cFE. https://github.com/ArielSAdamsNASA/cFE/actions/runs/861283509/workflow
Jobs were failing when the entire path of the configuration file were not used. Have to use nasa/cFE/.github/codeql/config-name@branch-name. The branch must be included in the path.
The CodeQL analysis workflow will fail for this PR since it is calling for a configuration file in main the main branch. It will not work until the configuration files are merged into main.
In the screenshot is the same workflow as in this pull request, but the configuration path is changed to the forked repo and tested branch.
Expected behavior changes
There should be one job for security queries and one job for JPL and MISRA queries.
Third party code
Skip duplicate workflows license: https://github.com/fkirc/skip-duplicate-actions/blob/master/LICENSE
CodeQL license: https://github.com/github/codeql-action/blob/main/LICENSE
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal