-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #264, CodeQL Dependent on a Successful Build #304
Fix #264, CodeQL Dependent on a Successful Build #304
Conversation
I wonder if we can skip the tests altogether. Also, look into making the CodeQL workflow dependent on the "build and run" one https://github.com/marketplace/actions/workflow-run-conclusion-dispatch-action |
@astrogeco Can you specify what you mean by the build and run one? Like the workflow or a job? |
Sorry, meant the build and run workflow |
3c9db50
to
a003af2
Compare
So, build-cfs-deprecated.yml or build-cfs.yml? I feel like it would be best to just build and run cFS in jobs. I don't quite understand the action you provided and the workflow_run trigger isn't working. https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_run
|
The idea was to wait for the build and test workflow defined in build-cfs.yml to successfully execute and avoid building cFS multiple times in different workflows. It might not be worth the complexity though. |
75ee066
to
5724e49
Compare
5724e49
to
7c04605
Compare
.github/workflows/codeql-build.yml
Outdated
do_not_skip: '["pull_request", "workflow_dispatch", "schedule"]' | ||
|
||
|
||
jobs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this won't run twice without the check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL is only triggered on workflow_run, but I can keep the check there for now.
2649a44
to
41f6b61
Compare
41f6b61
to
a146436
Compare
CCB:2021-07-21 APPROVED |
Checklist (Please check before submitting)
Describe the contribution
Fixes #264
Added workflow_run event as a trigger.
Testing performed
Tested on fork. Triggered on workflow_run. Will work once workflow is integrated in main.
Expected behavior changes
If Build, Test, and Run [OMIT_DEPRECATED=true] fails, then CodeQL will not run.
Additional context
https://stackoverflow.com/questions/62750603/github-actions-trigger-another-action-after-one-action-is-completed
Build, Test, and Run [OMIT_DEPRECATED=true] must be renamed.
Tried
Build, Test, and Run name works.
Downside is that CodeQL workflow does not name what triggered the workflow such as the name of the commit. Instead it always says the name of the workflow which is CodeQL Analysis.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal