From 6e3aceadec3ae599a61c73cb90b7b1964e86bbaf Mon Sep 17 00:00:00 2001 From: ArielSAdamsNASA Date: Fri, 21 May 2021 08:20:49 -0500 Subject: [PATCH 1/2] Fix #86, Implement Coding Standard in CodeQL --- .github/workflows/codeql-build.yml | 63 ++++++++++++++++++++++++++++-- 1 file changed, 60 insertions(+), 3 deletions(-) diff --git a/.github/workflows/codeql-build.yml b/.github/workflows/codeql-build.yml index cbeb3d4..f6b7b5c 100644 --- a/.github/workflows/codeql-build.yml +++ b/.github/workflows/codeql-build.yml @@ -2,9 +2,9 @@ name: "CodeQL Analysis" on: push: + pull_request: branches: - main - pull_request: env: SIMULATION: native @@ -13,8 +13,23 @@ env: BUILDTYPE: release jobs: + #Checks for duplicate actions. Skips push actions if there is a matching or duplicate pull-request action. + check-for-duplicates: + runs-on: ubuntu-latest + # Map a step output to a job output + outputs: + should_skip: ${{ steps.skip_check.outputs.should_skip }} + steps: + - id: skip_check + uses: fkirc/skip-duplicate-actions@master + with: + concurrent_skipping: 'same_content' + skip_after_successful_duplicate: 'true' + do_not_skip: '["pull_request", "workflow_dispatch", "schedule"]' - CodeQL-Build: + CodeQL-Security-Build: + needs: check-for-duplicates + if: ${{ needs.check-for-duplicates.outputs.should_skip != 'true' }} runs-on: ubuntu-18.04 timeout-minutes: 15 @@ -38,7 +53,7 @@ jobs: uses: github/codeql-action/init@v1 with: languages: c - queries: +security-extended, security-and-quality + config-file: nasa/cFS/.github/codeql/codeql-security.yml@main # Setup the build system - name: Set up for build @@ -53,3 +68,45 @@ jobs: - name: Perform CodeQL Analysis uses: github/codeql-action/analyze@v1 + + CodeQL-Coding-Standard-Build: + needs: check-for-duplicates + if: ${{ needs.check-for-duplicates.outputs.should_skip != 'true' }} + runs-on: ubuntu-18.04 + timeout-minutes: 15 + + steps: + # Checks out a copy of your repository on the ubuntu-latest machine + - name: Checkout bundle + uses: actions/checkout@v2 + with: + repository: nasa/cFS + submodules: true + + - name: Checkout submodule + uses: actions/checkout@v2 + with: + path: apps/ci_lab + + - name: Check versions + run: git submodule + + - name: Initialize CodeQL + uses: github/codeql-action/init@v1 + with: + languages: c + config-file: nasa/cFS/.github/codeql/codeql-coding-standard.yml@main + + # Setup the build system + - name: Set up for build + run: | + cp ./cfe/cmake/Makefile.sample Makefile + cp -r ./cfe/cmake/sample_defs sample_defs + make prep + + # Build the code + - name: Build + run: make ci_lab + + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v1 \ No newline at end of file From 4d5a6114e6a4eca0994e747de31c85f422eae05e Mon Sep 17 00:00:00 2001 From: "Gerardo E. Cruz-Ortiz" <59618057+astrogeco@users.noreply.github.com> Date: Thu, 24 Jun 2021 12:16:16 -0400 Subject: [PATCH 2/2] IC:2021-06-22, Bump to v2.4.0-rc1+dev42 *Development Version* - Remove github issue references in readme's version history --- README.md | 7 ++++++- fsw/src/ci_lab_version.h | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 05d3539..afac372 100644 --- a/README.md +++ b/README.md @@ -11,6 +11,11 @@ ci_lab is a simple command uplink application that accepts CCSDS telecommand pac ## Version History +### Development Build: v2.4.0-rc1+dev42 + +- Implement Coding Standard in CodeQL workflow +- See and + ### Development Build: v2.4.0-rc1+dev39 - Removes unnecessary call to `CFE_ES_RegisterApp()` since app registration is done automatically. @@ -24,7 +29,7 @@ ci_lab is a simple command uplink application that accepts CCSDS telecommand pac ### Development Build: v2.4.0-rc1+dev25 -- Fix #74, Add Testing Tools to the Security Policy +- Add Testing Tools to the Security Policy - See ### Development Build: v2.4.0-rc1+dev14 diff --git a/fsw/src/ci_lab_version.h b/fsw/src/ci_lab_version.h index 3b2cb0a..b52fdcc 100644 --- a/fsw/src/ci_lab_version.h +++ b/fsw/src/ci_lab_version.h @@ -32,7 +32,7 @@ /* Development Build Macro Definitions */ -#define CI_LAB_BUILD_NUMBER 39 /*!< Development Build: Number of commits since baseline */ +#define CI_LAB_BUILD_NUMBER 42 /*!< Development Build: Number of commits since baseline */ #define CI_LAB_BUILD_BASELINE \ "v2.4.0-rc1" /*!< Development Build: git tag that is the base for the current development */