Fix #147, reorganize source files #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/ | ||
|
|
||
| void CI_LAB_ProcessGroundCommand(const CFE_SB_Buffer_t *SBBufPtr) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| /* Verify command packet length */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/ | ||
| bool CI_LAB_VerifyCmdLength(const CFE_MSG_Message_t *MsgPtr, size_t ExpectedLength) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
Organize source files into a directory and naming pattern that is compliant with the CFE current recommended practice. Configurable items are moved to the respective header files and documentation is added to indicate what they do.
jphickey
force-pushed
the
fix-147-reorg
branch
from
c99def0
to
04e089e
Compare
| /* 3. Request for housekeeping telemetry packet (from HS task) */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void CI_LAB_TaskPipe(const CFE_SB_Buffer_t *SBBufPtr) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 30, 2023
*Combines:* sample_app v1.3.0-rc4+dev56 ci_lab v2.5.0-rc4+dev51 sch_lab v2.5.0-rc4+dev61 **Includes:** *sample_app* - nasa/sample_app#189 - nasa/sample_app#195 - nasa/sample_app#198 - nasa/sample_app#201 - nasa/sample_app#205 - nasa/sample_app#208 - nasa/sample_app#209 *ci_lab* - nasa/ci_lab#148 *sch_lab* - nasa/sch_lab#151 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 30, 2023
*Combines:* sample_app v1.3.0-rc4+dev56 ci_lab v2.5.0-rc4+dev51 sch_lab v2.5.0-rc4+dev61 **Includes:** *sample_app* - nasa/sample_app#189 - nasa/sample_app#195 - nasa/sample_app#198 - nasa/sample_app#201 - nasa/sample_app#205 - nasa/sample_app#208 - nasa/sample_app#209 *ci_lab* - nasa/ci_lab#148 *sch_lab* - nasa/sch_lab#151 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Organize source files into a directory and naming pattern that is compliant with the CFE current recommended practice.
Configurable items are moved to the respective header files and documentation is added to indicate what they do.
Fixes #147
Testing performed
Build and run tests
Expected behavior changes
None
System(s) tested on
Debian
Additional context
Makes CI_LAB more compliant with CFS coding patterns
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.