Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL-80: Update ummSubscriptionVersion #136

Merged
merged 1 commit into from
Oct 4, 2024
Merged

GQL-80: Update ummSubscriptionVersion #136

merged 1 commit into from
Oct 4, 2024

Conversation

macrouch
Copy link
Contributor

@macrouch macrouch commented Oct 4, 2024

Overview

What is the feature?

Updates the ummSubscriptionVersion to 1.1.1

What areas of the application does this impact?

Subscription mutations

Testing

Reproduction steps

Create mutation:

mutation CreateSubscription($params: CreateSubscriptionInput) {
  createSubscription(
    params: $params
  ) {
    conceptId
    revisionId
    nativeId
  }
}

Variables:

{
  "params": {
    "name": "Example Subscription",
    "query": "polygon=-18,-78,-13,-74,-16,-73,-22,-77,-18,-78",
    "subscriberId": "YOUR USERNAME",
    "type": "collection"
  }
}

Also remember to include an EDL token with the request.

Update mutation:
Be sure to copy the nativeId out of the response from the create mutation

mutation UpdateSubscription($params: UpdateSubscriptionInput) {
  updateSubscription(params: $params) {
    conceptId
    revisionId
  }
}

Variables:

{
  "params": {
    "nativeId": "NATIVEID FROM CREATE MUTATION",
    "name": "Example Subscription 2",
    "query": "polygon=-18,-78,-13,-74,-16,-73,-22,-77,-18,-78",
    "subscriberId": "YOUR USERNAME",
    "type": "collection"
  }
}

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d2f9e08) to head (118183c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #136   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         2344      2344           
  Branches       262       262           
=========================================
  Hits          2344      2344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macrouch macrouch merged commit 2ae05dd into main Oct 4, 2024
8 checks passed
@macrouch macrouch deleted the GQL-80-2 branch October 4, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants