-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GQL-91: Added "standardProduct" to schema #142
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 106 106
Lines 2410 2410
Branches 273 273
=========================================
Hits 2410 2410 ☔ View full report in Codecov by Sentry. |
Remember to update the commits and name of this PR to |
Please complete the PR template as well. Testing steps are very useful for reviewers trying to switch contexts to review your changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't working for me. Regardless of the value I pass in to the standardProduct
parameter I get the same results back.
Would not getting different/the same result back be in scope? I thought we just need to make sure the value was able to be accepted by graphql. This would be a cmr ticket if the results don't work right? |
First step is to verify that the parameter is being sent to CMR. Results coming back the same regardless of the parameter value would indicate it isn't |
…he query is made with the param correctly.
Overview
What is the feature?
Allow "standardProduct" to be used in query params for collections queries.
What is the Solution?
Added "standardProduct" to the collections schema.
What areas of the application does this impact?
src/cmr/concepts/collection.js
src/types/collection.graphql
Testing
Reproduction steps
Graphql Testing
Ensure that querying with standardProduct as a query parameter does not return errors
QUERY:
PARAMS:
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist