Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-2673: Lazy load Leaflet #1218

Open
mreese84 opened this issue Oct 1, 2020 · 5 comments
Open

EDSC-2673: Lazy load Leaflet #1218

mreese84 opened this issue Oct 1, 2020 · 5 comments

Comments

@mreese84
Copy link
Contributor

mreese84 commented Oct 1, 2020

Description

In an effort to improve initial load times, we should lazy load Leaflet js. We want to be sure to do this in a way that does not degrade the UX of the initial application load.

Acceptance Criteria

  • Leaflet/map javascript is only loaded in pages that render the map (/search/*, /project)
  • Once the map component is mounted/rendered, it should not be remounted
@mmayadag
Copy link

mmayadag commented Oct 4, 2020

Hi, I would like to work on this issue, could you assign me it?

@mreese84
Copy link
Contributor Author

mreese84 commented Oct 4, 2020

Go for it!

@mmayadag
Copy link

Hi @mreese84 ,
I used lazy react component with "Suspense" for "EdscMapContainer".( search page in static/src/js/App.js & static/src/js/routes/Project/Project.js )

Its improves initial app load times.

  • Nothing changed for map component still has same behaviour.
  • its renders once mounted

Could you give me feedback for it?
Do you want me to make another development?
Before i create tests, can we setup small 5mins talk for it ?
Thanks

@abbottry
Copy link
Member

If you'd like feedback, please open a Pull Request with your changes. We're not able to chat but we can provide any necessary feedback via the PR.

@jalajcodes
Copy link

If you folks are still interested in getting it resolved I'd like to work on it @abbottry @mreese84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants