Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require displayable types in records #576

Open
jwest115 opened this issue Jan 17, 2025 · 0 comments · May be fixed by #577
Open

Require displayable types in records #576

jwest115 opened this issue Jan 17, 2025 · 0 comments · May be fixed by #577
Assignees
@jwest115
Labels
bug Something isn't working semantics Issues related to semantics
Milestone
v2.3.0

Comments

@jwest115
Copy link
Collaborator

jwest115 commented Jan 17, 2025 •
edited by bocchino
Loading

Currently an internal error is thrown if an abstract type is used in a record "Exception in thread "main" internal error: type not supported in JSON dictionary spec". We can fix this by not allowing abstract types to be present in records:

  • Update spec
  • Update record semantics to include non-displayable type check
@jwest115 jwest115 added bug Something isn't working semantics Issues related to semantics labels Jan 17, 2025
@jwest115 jwest115 self-assigned this Jan 17, 2025
This was referenced Jan 17, 2025
Closed
Open
@bocchino bocchino changed the title Make abstract types non-displayable in records Require displayable types in records Jan 22, 2025
@bocchino bocchino mentioned this issue Jan 23, 2025
Open
@bocchino bocchino added this to the v2.3.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwest115 jwest115

Labels
bug Something isn't working semantics Issues related to semantics
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging a pull request may close this issue.

Require displayable types in records jwest115/fpp
2 participants
@bocchino @jwest115