Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Conductor should include useful built-in time spans and history tracking #3213

Closed
charlesh88 opened this issue Jul 20, 2020 · 11 comments · Fixed by #3270
Closed

Time Conductor should include useful built-in time spans and history tracking #3213

charlesh88 opened this issue Jul 20, 2020 · 11 comments · Fixed by #3270
Labels
help_wanted Help the Open MCT project! needs:e2e Needs an e2e test type:enhancement

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Jul 20, 2020

Screen Shot 2020-07-20 at 10 47 33 AM

In a similar fashion to a feature recently added for Fixed Timespan mode the Time Conductor's real-time mode should have useful pre-determined timespans available to the user via a menu. Additionally, we should watch, remember and make those available in the same way as well. Ideally, these are configurable per deployment.

Timespans:

00:60:00 - 00:00:00
00:30:00 - 00:00:00
00:15:00 - 00:00:00
00:05:00 - 00:00:00
00:01:00 - 00:00:00

@mudinthewater
Copy link

While you're doing this please make sure that it works for spans greater than 24 hours. Your timespan example doesn't include that case.

@charlesh88
Copy link
Contributor Author

@mudinthewater After discussion with @akhenry extending the time frame beyond 24 hours is non-trivial, so I've broken that into its own issue: #3220.

@jvigliotta
Copy link
Contributor

Testing

  • clear out any current history tracking from local storage
    • delete localStorage['tcHistoryRealtime']; delete localStorage['tcHistory'];
  • Open up a plot or SWG (anything you can verify timespans and offsets changing)
  • Switch between realtime (local clock) and fixed time modes
  • Choose preset times and enter in your own times in both modes
  • verify that
    • the selections are modifying the view offsets and time bounds accordingly
    • it's tracking your selections correctly
    • it's not allowing duplicates
    • if you close your browser and open again, that the same history presets are restored

@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Nov 2, 2020

Testathon 11/2/2020: Not able to verify, can not see predefined options such as Last day, Last hour etc.

TODO: Add correct configuration and test again.

@charlesh88
Copy link
Contributor Author

Verified partially fixed Testathon 11-02-20: saves and applies user-changed historical values, but isn't displaying any pre-configured ranges, but should.

@charlesh88 charlesh88 reopened this Nov 6, 2020
@charlesh88
Copy link
Contributor Author

Reopening to get useful timespans in the deployment.

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jun 25, 2021

Let's retest with the viper-openmct changes in the next testathon. Setup needed.

@charlesh88
Copy link
Contributor Author

Fixed.

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Jul 18, 2022
@unlikelyzero unlikelyzero added the help_wanted Help the Open MCT project! label Jul 18, 2022
@unlikelyzero
Copy link
Collaborator

e2e testing notes

timeConductor.e2e.spec.js

History has default values

  1. Open history values in timeConductor and validate default selections

History appears for recently entered

  1. Modify start, end and offset times of time conductor to create a "history"
  2. Switch to Local Clock
  3. Open 'History' and look for time conductor history from step 1.

Duplicates do not appear
Repeat 'History appears for recently entered' three times
Verify that it does not appear as 3 separate entries

Verify that values appear in localStorage and can be loaded from SessionStorage file
Reach out to an Open MCT dev for more!

@loftwah
Copy link
Contributor

loftwah commented Jul 18, 2022

I can definitely take a look at this.

@charlesh88
Copy link
Contributor Author

Fixed

@charlesh88 charlesh88 removed the bug:retest Retest without a specific milestone label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help_wanted Help the Open MCT project! needs:e2e Needs an e2e test type:enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants