Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Update references to 'networkidle' on navigation on network tests #7808

Closed
3 tasks
unlikelyzero opened this issue Aug 8, 2024 · 0 comments · Fixed by #7806
Closed
3 tasks

[e2e] Update references to 'networkidle' on navigation on network tests #7808

unlikelyzero opened this issue Aug 8, 2024 · 0 comments · Fixed by #7806
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Contributor

Summary

The new eslint plugin for playwright advocates for navigation waits on 'domcontendloaded' over 'networkidle' for good reasons: mostly to prevent laziness and flakiness.

In our case, we have network tests which explicit need to catch the number of returned network responses/requests and the only deterministic way to do that is through 'networkidle'.

  • Keep linting rule in place
  • Override per network test
  • Introduce @network annotation to tests which involve real network requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant