Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure memory is set in OS_stat handler #1210

Closed
skliper opened this issue Jan 18, 2022 · 0 comments · Fixed by #1211
Closed

Ensure memory is set in OS_stat handler #1210

skliper opened this issue Jan 18, 2022 · 0 comments · Fixed by #1211
Assignees
@skliper
Labels
draco-rc1 enhancement
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Jan 18, 2022

Is your feature request related to a problem? Please describe.
Risk of uninitialized variable use if buffer isn't set in OS_stat handler:

osal/src/ut-stubs/osapi-file-handlers.c

Lines 199 to 202 in 4cc6dbb

if (Status == OS_SUCCESS)
{
UT_Stub_CopyToLocal(UT_KEY(OS_stat), filestats, sizeof(*filestats));
}

Describe the solution you'd like
Initialize to zero if not fully set (provides default behavior)

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the Draco milestone Jan 18, 2022
@skliper skliper self-assigned this Jan 18, 2022
skliper added a commit to skliper/osal that referenced this issue Jan 18, 2022
@skliper
Fix nasa#1210, Set output in OS_stat handler
45ab4e1
@skliper skliper mentioned this issue Jan 18, 2022
Merged
astrogeco added a commit that referenced this issue Jan 19, 2022
@astrogeco
Merge pull request #1211 from skliper/fix1210-os_stat_handler_init
cf01555 
Fix #1210, Set output in OS_stat handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
draco-rc1 enhancement
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #1210, Set output in OS_stat handler skliper/osal
1 participant
@skliper