Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1252, condition variable API for OSAL #1278

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Aug 10, 2022

Checklist (Please check before submitting)

Describe the contribution
Implementation of condition variable API for OSAL

Currently implemented only for POSIX, RTEMS can be added with future commit.

Testing performed
Coverage and functional test of condvar API is included

Expected behavior changes
Adds condition variable API

System(s) tested on
Ubuntu 22.04

Additional context
The BP/DTN implementation (https://github.com/nasa/bplib) makes use of condition variables to signal between worker tasks. In order to support running this library natively, OSAL would need to provide this set of functionality.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey marked this pull request as draft August 10, 2022 20:37
This initial commit defines the conceptual condition variable API.
This is not implemented yet for any OS, but should be implementable on
POSIX, RTEMS, and VxWorks 7.x.  Older VxWorks releases may not have the
underlying support to implement this.
Adds a complete implementation of condition variables for POSIX.
Includes coverage and unit tests.

RTEMS and VxWorks will temporarily use a "no-condvar" placeholder
until an implementation for those systems is added.
@jphickey jphickey marked this pull request as ready for review August 23, 2022 21:11
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Sep 7, 2022
@dzbaker
Copy link
Collaborator

dzbaker commented Sep 8, 2022

CCB 8 September 2022: @jphickey will write issues for extending to additional platforms.

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Sep 8, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Sep 8, 2022
*Combines:*

osal v7.0.0-rc4+dev108

**Includes:**

- nasa/osal#1278, condition variable API for OSAL

Co-authored by: Joseph Hickey  <jphickey@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Sep 8, 2022
2 tasks
@dzbaker dzbaker merged commit 28d477c into nasa:main Sep 8, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Sep 8, 2022
*Combines:*

osal v7.0.0-rc4+dev108

**Includes:**

- nasa/osal#1278, condition variable API for OSAL

Co-authored by: Joseph Hickey  <jphickey@users.noreply.github.com>
@jphickey jphickey deleted the fix-1252-condvar-api branch October 18, 2022 13:55
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants