Overwriting unused values in variables

[skliper]

As reported by cppcheck performance
applied to the "ic-gll-jsc-merge" branch:

Variable % is reassigned a value before the old one has been used.

This message is present in 17 files:

{{{
osal/src/os/vxworks6/osapi.c
osal/src/os/vxworks6/osnetwork.c
osal/src/tests/mutex-test/mutex-test.c
osal/src/unit-tests-coverage/osapi-test/osapi_testcase_binsem.c
osal/src/unit-tests-coverage/osapi-test/osapi_testcase_queues.c
osal/src/unit-tests-coverage/osapi-test/osapi_testcase_tasks.c
osal/src/unit-tests-coverage/osapi-test/osapi_testcase_time_int.c
osal/src/unit-tests-coverage/osfileapi-test/osfileapi_testcase.c
osal/src/unit-tests-coverage/osfilesys-test/osfilesys_testcase.c
osal/src/unit-tests-coverage/osloader-test/osloader_testcase.c
osal/src/unit-tests-coverage/ostimer-test/ostimer_testcase.c
osal/src/unit-tests/oscore-test/ut_oscore_binsem_test.c
osal/src/unit-tests/oscore-test/ut_oscore_countsem_test.c
osal/src/unit-tests/oscore-test/ut_oscore_mutex_test.c
osal/src/unit-tests/oscore-test/ut_oscore_queue_test.c
osal/src/unit-tests/oscore-test/ut_oscore_task_test.c
osal/src/unit-tests/osfile-test/ut_osfile_dirio_test.c
}}}

Need to examine the fingered bits of code, see if any
of them need fixing, and figure out how to get cppcheck
to be happy.

[skliper]

Imported from trac issue 105. Created by glimes on 2015-10-20T19:31:52, last modified: 2019-08-14T14:11:46

[skliper]

Trac comment by glimes on 2015-12-22 16:33:44:

see #157 and #158

[skliper]

Related to fixes implemented in #308 and enforced in #314. No current plan to resolve style issues in test code. Closing as duplicate.