Fix #1188, Reuse CodeQL, Static Analysis, Format Check #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArielSAdamsNASA
force-pushed
the
fix-1188-reuse-workflows
branch
from
b8b8286
to
8c53a3a
Compare
ArielSAdamsNASA
added
the
CCB:Ready
skliper
reviewed
Oct 27, 2021
|
Are you planning to add |
ArielSAdamsNASA
force-pushed
the
fix-1188-reuse-workflows
branch
from
8c53a3a
to
7298f2d
Compare
Thanks for the catch, just added static analysis. |
This was referenced Oct 27, 2021
ArielSAdamsNASA
force-pushed
the
fix-1188-reuse-workflows
branch
from
7298f2d
to
2abd8e6
Compare
astrogeco
removed
the
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 20, 2022
*osal* nasa/osal#1206, Search global and local symbol tables nasa/osal#1201, Add missing space to UtAssert_STUB_COUNT nasa/osal#1202, Add UINT8 and UINT16 equivalents for UtAssert_UINT32_<Comparison> macros nasa/osal#1203, correct warnings on gcc11 nasa/osal#1211, Set output in OS_stat handler nasa/osal#1190, Reuse CodeQL, Static Analysis, Format Check *Authors* skliper jphickey kurtjd
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 21, 2022
Combines: nasa/cFE#2019, cFE v7.0.0-rc4+dev60 nasa/osal#1212, osal v6.0.0-rc4+dev29 nasa/sch_lab#105, sch_lab v2.5.0-rc4+dev13 Includes: *cFE* nasa/cFE#2033, Add CFE_ES_AppInfo_t element documentation nasa/cFE#2011, Reuse CodeQL, Static Analysis, and Format Check nasa/cFE#2015, Add FS Functional test nasa/cFE#2012, Fix mismatched foreach in cmake function nasa/cFE#2013, Improved code highlighting in cFE Application Developers Guide nasa/cFE#2027, CFE_FS_ParseInputFileNameEx avoid uninit var nasa/cFE#2031, Fix array length calculation for perf structs nasa/cFE#2023, Limit SBR UT loops nasa/cFE#2029, Initialize BlockData in ES UT nasa/cFE#2025, Fix osal_id_t type conversion in es_UT.c *osal* nasa/osal#1206, Search global and local symbol tables nasa/osal#1201, Add missing space to UtAssert_STUB_COUNT nasa/osal#1202, Add UINT8 and UINT16 equivalents for UtAssert_UINT32_<Comparison> macros nasa/osal#1203, correct warnings on gcc11 nasa/osal#1211, Set output in OS_stat handler nasa/osal#1190, Reuse CodeQL, Static Analysis, Format Check *other* nasa/sch_lab#104, Add option to configure base tick rate *Continuous Integration Updates* nasa/PSP#317, Reuse CodeQL, Static Analysis, and Format Check nasa/sample_lib#72, Reuse CodeQL, Static Analysis, and Format Check nasa/sample_app#162, Reuse CodeQL, Static Analysis, and Format Check nasa/ci_lab#100, Reuse CodeQL, Static Analysis, and Format Check nasa/to_lab#111, Reuse CodeQL, Static Analysis, and Format Check nasa/tblCRCTool#59, Reuse CodeQL, Static Analysis, and Format Check nasa/elf2cfetbl#97, Reuse CodeQL, Static Analysis, and Format Check nasa/cFS-GroundSystem#200, Reuse CodeQL, Static Analysis, and Format Check Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Kurtis Dinelle <kurtjd@users.noreply.github.com> Co-authored-by: Paul <paulober@users.noreply.github.com> Co-authored-by: Adrien Chardon <Nodraak@users.noreply.github.com>
astrogeco
added a commit
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #1188
Testing performed
Tested on forked repos.
OSAL Static Analysis Reuse: https://github.com/ArielSAdamsNASA/osal/actions/runs/1391621678
cFS Static Analysis Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1391690020
OSAL CodeQL Reuse cFE Build: https://github.com/ArielSAdamsNASA/osal/runs/4023159610?check_suite_focus=true
OSAL CodeQL Reuse OSAL Default: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702434
cFS CodeQL Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390777421
OSAL Format Check Reuse: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702433
cFS Format Check: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390865379
Expected behavior changes
cFS will hold the workflows for CodeQL, Static Analysis, and Format Check. These workflows will be called by all OSAL to reuse. These workflows will not work until nasa/cFS#386 is merged.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal