Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static analysis workflow missing duplicate check, restricting to main push, remove --quiet #70

Closed
skliper opened this issue Oct 22, 2021 · 1 comment
Closed

Static analysis workflow missing duplicate check, restricting to main push, remove --quiet #70

skliper opened this issue Oct 22, 2021 · 1 comment
Labels
continuous-integration duplicate This issue or pull request already exists

Comments

@skliper
Copy link
Contributor

skliper commented Oct 22, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Missing duplicate check, overly restrictive to main push:

sample_lib/.github/workflows/static-analysis.yml

Lines 4 to 12 in b500b02

on:
push:
branches:
- main
pull_request:
jobs:
static-analysis:

also should remove --quiet flag so files processed will be listed:

sample_lib/.github/workflows/static-analysis.yml

Line 26 in b500b02

run: cppcheck --force --inline-suppr --quiet . 2> cppcheck_err.txt

Describe the solution you'd like
Fix

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper changed the title Static analysis workflow missing duplicate check, restricting to main push Static analysis workflow missing duplicate check, restricting to main push, remove --quiet Oct 22, 2021
@skliper skliper assigned skliper and unassigned skliper Oct 22, 2021
@skliper
Copy link
Contributor Author

skliper commented Oct 28, 2021

OBE- #71

@skliper skliper closed this as completed Oct 28, 2021
@skliper skliper added the duplicate This issue or pull request already exists label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous-integration duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skliper