From 31db8c5d601e9c6a990f27df631c2b8043dde634 Mon Sep 17 00:00:00 2001 From: Dan Jordan Date: Tue, 7 Nov 2023 12:57:32 -0600 Subject: [PATCH] Address code review items --- .../MONTE_RUN_nominal/MonteCarlo_Meta_data_output | 14 +++++++------- .../verif_data/MonteCarlo_Meta_data_output | 14 +++++++------- .../mc_variable_random_normal.cc | 2 +- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/test/SIM_mc_generation/verif_data/MONTE_RUN_nominal/MonteCarlo_Meta_data_output b/test/SIM_mc_generation/verif_data/MONTE_RUN_nominal/MonteCarlo_Meta_data_output index 10a7bf409..f2bbb8e69 100644 --- a/test/SIM_mc_generation/verif_data/MONTE_RUN_nominal/MonteCarlo_Meta_data_output +++ b/test/SIM_mc_generation/verif_data/MONTE_RUN_nominal/MonteCarlo_Meta_data_output @@ -19,13 +19,13 @@ test.x_fixed_value_int: type=Constant, test.x_fixed_value_string: type=Constant, test.x_integer: type=Random, dispersion=Uniform, min_value=0, max_value=2, seed=1 test.x_line_command: type=Calculated, -test.x_normal: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=0, max_value=0, seed=2 -test.x_normal_length: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=0, max_value=0, seed=2 -test.x_normal_trunc[0]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=9, max_value=11, seed=2 -test.x_normal_trunc[1]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=9.5, max_value=10.7, seed=2 -test.x_normal_trunc[2]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=9.9, max_value=11, seed=2 -test.x_normal_trunc[3]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=9.9, max_value=0, seed=2 -test.x_normal_trunc[4]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=0, max_value=4, seed=2 +test.x_normal: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=0, max_value=0, seed=2 +test.x_normal_length: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=0, max_value=0, seed=2 +test.x_normal_trunc[0]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=9, max_value=11, seed=2 +test.x_normal_trunc[1]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=9.5, max_value=10.7, seed=2 +test.x_normal_trunc[2]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=9.9, max_value=11, seed=2 +test.x_normal_trunc[3]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=9.9, max_value=0, seed=2 +test.x_normal_trunc[4]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=0, max_value=4, seed=2 test.x_semi_fixed_value: type=Constant, test.x_string: type=Random, dispersion=Uniform, min_value=0, max_value=1, seed=3, values=["ABC","DEF",'GHIJKL',] test.x_uniform: type=Random, dispersion=Uniform, min_value=10, max_value=20, seed=0 diff --git a/test/SIM_mc_generation/verif_data/MonteCarlo_Meta_data_output b/test/SIM_mc_generation/verif_data/MonteCarlo_Meta_data_output index d81599a0d..a5dbca581 100644 --- a/test/SIM_mc_generation/verif_data/MonteCarlo_Meta_data_output +++ b/test/SIM_mc_generation/verif_data/MonteCarlo_Meta_data_output @@ -23,13 +23,13 @@ test.x_fixed_value_int: type=Constant, test.x_fixed_value_string: type=Constant, test.x_integer: type=Random, dispersion=Uniform, min_value=0, max_value=2, seed=1 test.x_line_command: type=Calculated, -test.x_normal: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=0, max_value=0, seed=2 -test.x_normal_length: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=0, max_value=0, seed=2 -test.x_normal_trunc[0]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=9, max_value=11, seed=2 -test.x_normal_trunc[1]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=9.5, max_value=10.7, seed=2 -test.x_normal_trunc[2]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=9.9, max_value=11, seed=2 -test.x_normal_trunc[3]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=9.9, max_value=0, seed=2 -test.x_normal_trunc[4]: type=Random, dispersion=Normal, mean=10, stddev=2 min_value=0, max_value=4, seed=2 +test.x_normal: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=0, max_value=0, seed=2 +test.x_normal_length: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=0, max_value=0, seed=2 +test.x_normal_trunc[0]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=9, max_value=11, seed=2 +test.x_normal_trunc[1]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=9.5, max_value=10.7, seed=2 +test.x_normal_trunc[2]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=9.9, max_value=11, seed=2 +test.x_normal_trunc[3]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=9.9, max_value=0, seed=2 +test.x_normal_trunc[4]: type=Random, dispersion=Normal, mean=10, stddev=2, min_value=0, max_value=4, seed=2 test.x_semi_fixed_value: type=Constant, test.x_string: type=Random, dispersion=Uniform, min_value=0, max_value=1, seed=3, values=["ABC","DEF",'GHIJKL',] test.x_uniform: type=Random, dispersion=Uniform, min_value=10, max_value=20, seed=0 diff --git a/trick_source/sim_services/MonteCarloGeneration/mc_variable_random_normal.cc b/trick_source/sim_services/MonteCarloGeneration/mc_variable_random_normal.cc index 6230fe1db..629be0c10 100644 --- a/trick_source/sim_services/MonteCarloGeneration/mc_variable_random_normal.cc +++ b/trick_source/sim_services/MonteCarloGeneration/mc_variable_random_normal.cc @@ -115,7 +115,7 @@ std::string MonteCarloVariableRandomNormal::summarize_variable() const std::ostringstream ss; ss << MonteCarloVariable::summarize_variable() << std::string(" dispersion=Normal,") << " mean=" << distribution.mean() << ", stddev=" << distribution.stddev() - << " min_value=" << min_value << ", max_value=" << max_value + << ", min_value=" << min_value << ", max_value=" << max_value << ", seed=" << seed_m; return (ss.str()); }