-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis::Objects methods need better name-spacing #153
Comments
I think prefixing all the methods would be far too ugly for typical use. A single class bringing in so many dependencies that the developer can't keep track of where its methods are coming from probably has opportunities to be broken up or simplified. (Yes, I know, ActiveRecord. That's part of why I don't like to use it.) I think a better answer would be an optional module that brought in Redis::Objects, but used |
Have you hit this in real world usage, or is this theoretical? |
Added a real world usage in #196 ;) |
At least we should output a "Warning: overwrite method" to developers. |
Closing as changing the namespace this late into the library's lifetime would be very disruptive. |
The instance method names Redis::Objects currently takes (
value
,list
,lock
,set
,etc) are too common, and can easily conflict with existing methods or method from 3rd party plugins.Should we add a
redis_
prefix, for instance, to the methods names?I'd love to help out write the patch when the discussion gets a result.
The text was updated successfully, but these errors were encountered: