Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(map): dashboards with no widgets fix [EP-2859] #151

Merged
merged 2 commits into from
Sep 17, 2020
Merged

fix(map): dashboards with no widgets fix [EP-2859] #151

merged 2 commits into from
Sep 17, 2020

Conversation

corinacioloca
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in /docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@corinacioloca corinacioloca merged commit 60141fb into develop Sep 17, 2020
@corinacioloca corinacioloca deleted the EP-2859-dashboard-crash branch September 17, 2020 10:36
genodeploy pushed a commit that referenced this pull request Sep 22, 2020
@semantic-release-bot
chore(release): 1.5.0 [skip ci]
09705b9 
# [1.5.0](v1.4.1...v1.5.0) (2020-09-22)

### Bug Fixes

* handle email-verified for authenticated users ([d0c9aae](d0c9aae))
* handle fallback route at router level logic ([e28001b](e28001b))
* **admin:** Add new user is not working [EP-2863] ([#153](#153)) ([1d83987](1d83987))
* **admin:** Error for missing provider and type is displayed when trying to save a layer [EP-2860] ([#152](#152)) ([55eff94](55eff94))
* **map:** dashboards with no widgets fix [EP-2859] ([#151](#151)) ([60141fb](60141fb))

### Features

* **admin:** post sign up page [EP-2179] ([1463f31](1463f31))
* **admin:** Update sidebar items when data changes [EP-2472] ([4a13cae](4a13cae))
* user profile [EP2585] ([c737e07](c737e07))
@dan-qc
Copy link
Contributor

dan-qc commented Sep 22, 2020

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iacoshoria iacoshoria iacoshoria approved these changes

@ancashoria ancashoria Awaiting requested review from ancashoria

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corinacioloca @dan-qc @iacoshoria