From 6e760970fb0ca685380bc81121d2078f915064eb Mon Sep 17 00:00:00 2001 From: Dave Foster Date: Tue, 23 Apr 2024 12:20:02 +0100 Subject: [PATCH] Fixes firmware version for H1 (G1) Incorrect input registers for Master, Manager, Slave firmware versions on H1 (G1), holding register values are correct. See https://github.com/nathanmarlor/foxess_modbus/issues/599 --- .../foxess_modbus/entities/entity_descriptions.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/custom_components/foxess_modbus/entities/entity_descriptions.py b/custom_components/foxess_modbus/entities/entity_descriptions.py index 899d66d..589e9b2 100644 --- a/custom_components/foxess_modbus/entities/entity_descriptions.py +++ b/custom_components/foxess_modbus/entities/entity_descriptions.py @@ -58,7 +58,7 @@ def _master_version(address: list[ModbusAddressSpec], is_hex: bool) -> ModbusVer yield _master_version( address=[ - ModbusAddressSpec(input=11016, models=Inv.H1_G1 | Inv.KH_PRE119), + ModbusAddressSpec(input=10016, models=Inv.H1_G1 | Inv.KH_PRE119), ModbusAddressSpec(holding=30016, models=Inv.H1_G1 | Inv.H1_LAN | Inv.H3_SET), ], is_hex=False, @@ -82,7 +82,7 @@ def _slave_version(address: list[ModbusAddressSpec], is_hex: bool) -> ModbusVers yield _slave_version( address=[ - ModbusAddressSpec(input=11017, models=Inv.H1_G1 | Inv.KH_PRE119), + ModbusAddressSpec(input=10017, models=Inv.H1_G1 | Inv.KH_PRE119), ModbusAddressSpec(holding=30017, models=Inv.H1_G1 | Inv.H1_LAN | Inv.H3_SET), ], is_hex=False, @@ -106,7 +106,7 @@ def _manager_version(address: list[ModbusAddressSpec], is_hex: bool) -> ModbusVe yield _manager_version( address=[ - ModbusAddressSpec(input=11018, models=Inv.H1_G1 | Inv.KH_PRE119), + ModbusAddressSpec(input=10018, models=Inv.H1_G1 | Inv.KH_PRE119), ModbusAddressSpec(holding=30018, models=Inv.H1_G1 | Inv.H1_LAN), ], is_hex=False,