Disables use of Pwr_Limit_Bat_Dn on H1 G2 #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This register is not supported on H1 Gen 2 which results in Force Charge fall back to Backup mode.
canton7
reviewed
Sep 14, 2024
| @@ -53,7 +53,7 @@ | |||
| max_soc=41010, | |||
| invbatpower=[31022], | |||
| battery_soc=[31024], | |||
| pwr_limit_bat_up=[44012], | |||
There was a problem hiding this comment.
Mind just adding a comment with a link to the discussion where we discovered this? Or I'm happy to.
There was a problem hiding this comment.
Sorry should have added that 😊
As discussed in this thread #666 (reply in thread)
There was a problem hiding this comment.
Ah sorry, I meant to the code. I'd do it myself, but you need to tick the little box allowing other people to make changes to the PR
canton7
reviewed
Sep 18, 2024
| @@ -53,7 +53,7 @@ | |||
| max_soc=41010, | |||
| invbatpower=[31022], | |||
| battery_soc=[31024], | |||
| pwr_limit_bat_up=[44012], | |||
| pwr_limit_bat_up=None, | |||
There was a problem hiding this comment.
Suggested change
| pwr_limit_bat_up=None, | |
| # Exists, but see https://github.com/nathanmarlor/foxess_modbus/discussions/666 | |
| pwr_limit_bat_up=None, |
FozzieUK1
approved these changes
Sep 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This register is not supported on H1 Gen 2 which results in Force Charge fall back to Backup mode.