Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] jwt/issuerkey/nametag/tags to monitoring and event endpoints #1830

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

matthiashanel
Copy link
Contributor

Also added a trace on jwt authentication

Signed-off-by: Matthias Hanel mh@synadia.com

[53472] [TRC] 127.0.0.1:51931 - cid:3 - "v1.11.0:go" - Authenticated JWT: Client "UAW2WHOE5AKJHEWVHJJMDWSVIN4BHU2HGNFKS4ZL2JOZ5RN774CP3ZVF" (claim-name: "a name", claim-tags: ["tags" "other"]) signed with "ACMAPDNT4LQZU6GYD22JVXLUZJT6AK4ONHKIB4TSJEAUHAEOONFLY22R" by Account "ACMAPDNT4LQZU6GYD22JVXLUZJT6AK4ONHKIB4TSJEAUHAEOONFLY22R" (claim-name: "", claim-tags: []) signed with "OCAT33MTVU2VUOIMGNGUNXJ66AH2RLSDAF3MUBCYAY5QMIL65NQM6XQG"
[53472] [TRC] 127.0.0.1:51932 - cid:4 - "v1.11.0:go" - Authenticated JWT: Client "UAW2WHOE5AKJHEWVHJJMDWSVIN4BHU2HGNFKS4ZL2JOZ5RN774CP3ZVF" (claim-name: "a name", claim-tags: ["tags" "other"]) signed with "ACMAPDNT4LQZU6GYD22JVXLUZJT6AK4ONHKIB4TSJEAUHAEOONFLY22R" by Account "ACMAPDNT4LQZU6GYD22JVXLUZJT6AK4ONHKIB4TSJEAUHAEOONFLY22R" (claim-name: "some account", claim-tags: ["foo" "bar"]) signed with "OCAT33MTVU2VUOIMGNGUNXJ66AH2RLSDAF3MUBCYAY5QMIL65NQM6XQG"
[53472] [TRC] 127.0.0.1:51933 - cid:5 - "v1.11.0:go:conn name" - Authenticated JWT: Client "UAW2WHOE5AKJHEWVHJJMDWSVIN4BHU2HGNFKS4ZL2JOZ5RN774CP3ZVF" (claim-name: "a name", claim-tags: ["tags" "other"]) signed with "ACMAPDNT4LQZU6GYD22JVXLUZJT6AK4ONHKIB4TSJEAUHAEOONFLY22R" by Account "ACMAPDNT4LQZU6GYD22JVXLUZJT6AK4ONHKIB4TSJEAUHAEOONFLY22R" (claim-name: "some account", claim-tags: ["foo" "bar"]) signed with "OCAT33MTVU2VUOIMGNGUNXJ66AH2RLSDAF3MUBCYAY5QMIL65NQM6XQG"
[53472] [TRC] 127.0.0.1:51934 - cid:6 - "v1.11.0:go" - Authenticated JWT: Client "UABC2XJEOWPA4DDDYKIDVS24SOLYTCILDFCHAGDG3JNS3RR6O77ZAJK3" (claim-name: "a name", claim-tags: ["tags" "other"]) signed with "AD7EMU4HIRDKAUIY5KURVIY4BEECIBJY4E6FQEL7OBVOGXZHYPXHLTAF" by Account "AD7EMU4HIRDKAUIY5KURVIY4BEECIBJY4E6FQEL7OBVOGXZHYPXHLTAF" (claim-name: "some account", claim-tags: ["foo" "bar"]) signed with "OCAT33MTVU2VUOIMGNGUNXJ66AH2RLSDAF3MUBCYAY5QMIL65NQM6XQG"
[53472] [TRC] 127.0.0.1:51935 - cid:7 - "v1.11.0:go" - Authenticated JWT: Client "UAW2WHOE5AKJHEWVHJJMDWSVIN4BHU2HGNFKS4ZL2JOZ5RN774CP3ZVF" (claim-name: "a name", claim-tags: ["tags" "other"]) signed with "ACMAPDNT4LQZU6GYD22JVXLUZJT6AK4ONHKIB4TSJEAUHAEOONFLY22R" by Account "ACMAPDNT4LQZU6GYD22JVXLUZJT6AK4ONHKIB4TSJEAUHAEOONFLY22R" (claim-name: "some account", claim-tags: ["foo" "bar"]) signed with "OCAT33MTVU2VUOIMGNGUNXJ66AH2RLSDAF3MUBCYAY5QMIL65NQM6XQG"
[53472] [TRC] 127.0.0.1:51937 - cid:9 - "v1.11.0:go" - Authenticated JWT: Client "UABC2XJEOWPA4DDDYKIDVS24SOLYTCILDFCHAGDG3JNS3RR6O77ZAJK3" (claim-name: "a name", claim-tags: ["tags" "other"]) signed with "AD7EMU4HIRDKAUIY5KURVIY4BEECIBJY4E6FQEL7OBVOGXZHYPXHLTAF" by Account "AD7EMU4HIRDKAUIY5KURVIY4BEECIBJY4E6FQEL7OBVOGXZHYPXHLTAF" (claim-name: "some account", claim-tags: ["foo" "bar"]) signed with "OCAT33MTVU2VUOIMGNGUNXJ66AH2RLSDAF3MUBCYAY5QMIL65NQM6XQG"

@matthiashanel matthiashanel changed the title [added] jwt/issuerkey/nametag/tags to monitoring and event endpoings [added] jwt/issuerkey/nametag/tags to monitoring and event endpoints Jan 21, 2021
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think setting fields in the client during auth should be protected.
Also, I wonder if this needs separate configuration to be activated? Not sure if in the use case this came up from, user would be willing to run under -V (which generates a lot of output) in order to get this trace. Also wonder if there is anything sensitive in this trace, which would make the opt-in option even more necessary.

server/auth.go Show resolved Hide resolved
Also added a trace on jwt authentication

Signed-off-by: Matthias Hanel <mh@synadia.com>
@matthiashanel
Copy link
Contributor Author

I think setting fields in the client during auth should be protected.
Also, I wonder if this needs separate configuration to be activated? Not sure if in the use case this came up from, user would be willing to run under -V (which generates a lot of output) in order to get this trace. Also wonder if there is anything sensitive in this trace, which would make the opt-in option even more necessary.

I spoke to them and for now I'll keep it at debug, hoping that the system eventing stuff is good enough for them.
If it's not, they'll let me know. then we can talk about possibly adding a switch for this trace.

Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants