-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[added] jwt/issuerkey/nametag/tags to monitoring and event endpoints #1830
Conversation
42fa4f8
to
931816e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think setting fields in the client during auth should be protected.
Also, I wonder if this needs separate configuration to be activated? Not sure if in the use case this came up from, user would be willing to run under -V
(which generates a lot of output) in order to get this trace. Also wonder if there is anything sensitive in this trace, which would make the opt-in option even more necessary.
Also added a trace on jwt authentication Signed-off-by: Matthias Hanel <mh@synadia.com>
I spoke to them and for now I'll keep it at debug, hoping that the system eventing stuff is good enough for them. |
Signed-off-by: Matthias Hanel <mh@synadia.com>
931816e
to
5fb7a03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also added a trace on jwt authentication
Signed-off-by: Matthias Hanel mh@synadia.com