From 181be9e1607151454ff007995a42b4e49b404da9 Mon Sep 17 00:00:00 2001
From: Tomasz Pietrek <tomasz@nats.io>
Date: Fri, 24 May 2024 15:21:12 +0200
Subject: [PATCH] [FIXED] Object Store compatibility tests (#1637)

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
---
 test/compat_test.go | 45 +++++++++------------------------------------
 1 file changed, 9 insertions(+), 36 deletions(-)

diff --git a/test/compat_test.go b/test/compat_test.go
index 3c2751480..d7f3cb7fb 100644
--- a/test/compat_test.go
+++ b/test/compat_test.go
@@ -45,10 +45,7 @@ type objectStepConfig[T any] struct {
 
 func TestCompatibilityObjectStoreDefaultBucket(t *testing.T) {
 	t.Parallel()
-	nc, err := nats.Connect(nats.DefaultURL, nats.Timeout(1*time.Hour))
-	if err != nil {
-		t.Fatalf("Error connecting to NATS: %v", err)
-	}
+	nc := connect(t)
 	js, err := jetstream.New(nc)
 	if err != nil {
 		t.Fatalf("Error connecting to NATS: %v", err)
@@ -85,10 +82,7 @@ func TestCompatibilityObjectStoreDefaultBucket(t *testing.T) {
 
 func TestCompatibilityObjectStoreCustomBucket(t *testing.T) {
 	t.Parallel()
-	nc, err := nats.Connect(nats.DefaultURL, nats.Timeout(1*time.Hour))
-	if err != nil {
-		t.Fatalf("Error connecting to NATS: %v", err)
-	}
+	nc := connect(t)
 	js, err := jetstream.New(nc)
 	if err != nil {
 		t.Fatalf("Error connecting to NATS: %v", err)
@@ -131,10 +125,7 @@ func TestCompatibilityObjectStoreGetObject(t *testing.T) {
 		Object string `json:"object"`
 	}
 
-	nc, err := nats.Connect(nats.DefaultURL, nats.Timeout(1*time.Hour))
-	if err != nil {
-		t.Fatalf("Error connecting to NATS: %v", err)
-	}
+	nc := connect(t)
 	js, err := jetstream.New(nc)
 	if err != nil {
 		t.Fatalf("Error connecting to NATS: %v", err)
@@ -186,10 +177,7 @@ func TestCompatibilityObjectStoreGetObject(t *testing.T) {
 func TestCompatibilityObjectStorePutObject(t *testing.T) {
 	t.Parallel()
 
-	nc, err := nats.Connect(nats.DefaultURL, nats.Timeout(1*time.Hour))
-	if err != nil {
-		t.Fatalf("Error connecting to NATS: %v", err)
-	}
+	nc := connect(t)
 	js, err := jetstream.New(nc)
 	if err != nil {
 		t.Fatalf("Error connecting to NATS: %v", err)
@@ -239,10 +227,7 @@ func TestCompatibilityObjectStorePutObject(t *testing.T) {
 func TestCompatibilityObjectStoreUpdateMetadata(t *testing.T) {
 	t.Parallel()
 
-	nc, err := nats.Connect(nats.DefaultURL, nats.Timeout(1*time.Hour))
-	if err != nil {
-		t.Fatalf("Error connecting to NATS: %v", err)
-	}
+	nc := connect(t)
 	js, err := jetstream.New(nc)
 	if err != nil {
 		t.Fatalf("Error connecting to NATS: %v", err)
@@ -287,10 +272,7 @@ func TestCompatibilityObjectStoreWatch(t *testing.T) {
 		Object string `json:"object"`
 	}
 
-	nc, err := nats.Connect(nats.DefaultURL, nats.Timeout(1*time.Hour))
-	if err != nil {
-		t.Fatalf("Error connecting to NATS: %v", err)
-	}
+	nc := connect(t)
 	js, err := jetstream.New(nc)
 	if err != nil {
 		t.Fatalf("Error connecting to NATS: %v", err)
@@ -365,10 +347,7 @@ func TestCompatibilityObjectStoreWatchUpdates(t *testing.T) {
 		Object string `json:"object"`
 	}
 
-	nc, err := nats.Connect(nats.DefaultURL, nats.Timeout(1*time.Hour))
-	if err != nil {
-		t.Fatalf("Error connecting to NATS: %v", err)
-	}
+	nc := connect(t)
 	js, err := jetstream.New(nc)
 	if err != nil {
 		t.Fatalf("Error connecting to NATS: %v", err)
@@ -421,10 +400,7 @@ func TestCompatibilityObjectStoreGetLink(t *testing.T) {
 		Object string `json:"object"`
 	}
 
-	nc, err := nats.Connect(nats.DefaultURL, nats.Timeout(1*time.Hour))
-	if err != nil {
-		t.Fatalf("Error connecting to NATS: %v", err)
-	}
+	nc := connect(t)
 	js, err := jetstream.New(nc)
 	if err != nil {
 		t.Fatalf("Error connecting to NATS: %v", err)
@@ -481,10 +457,7 @@ func TestCompatibilityObjectStorePutLink(t *testing.T) {
 		LinkName string `json:"link_name"`
 	}
 
-	nc, err := nats.Connect(nats.DefaultURL, nats.Timeout(1*time.Hour))
-	if err != nil {
-		t.Fatalf("Error connecting to NATS: %v", err)
-	}
+	nc := connect(t)
 	js, err := jetstream.New(nc)
 	if err != nil {
 		t.Fatalf("Error connecting to NATS: %v", err)