Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Objectstore Base64URL encoding bits #557

Open
to11mtm opened this issue Jul 9, 2024 · 0 comments · May be fixed by #565
Open

Optimize Objectstore Base64URL encoding bits #557

to11mtm opened this issue Jul 9, 2024 · 0 comments · May be fixed by #565
Assignees

Comments

@to11mtm
Copy link
Collaborator

to11mtm commented Jul 9, 2024

Proposed change

From #549:

While converting things to have System.Text.Json handle Base64 encoding for us, other opportunities came up.

I think we can also obviate a decent amount of code in ObjectStore
(snip)
Although, not sure if we should keep that in same PR or separate, just for sake of sizing... open to opinions here.
Edit: Actually I may be off on that on some level, Base64URL != Base64... so I'd say keep it separated.

CC:
@galvesribeiro (Thanks for the feedback and inspiration on this issue btw! <3)

Use case

Eliminating intermediary string allocations here (i.e. on SHA checks) would be a perf and memory improvement if we do it well.

This would benefit users of ObjectStore, especially in high load environments.

Contribution

I'd be happy to add it to my backlog? 😅 If someone else wants to give it a go, that's awesome too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant