Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README suggestion #152

Open
pkieltyka opened this issue Sep 21, 2017 · 4 comments
Open

README suggestion #152

pkieltyka opened this issue Sep 21, 2017 · 4 comments

Comments

@pkieltyka
Copy link

Hi,

go-nats-streaming is the Go client for https://github.com/nats-io/nats-streaming-server ? is that correct? if so, please mention that in the README. The description nor README mention its a client for specifically the nats streaming server.

Side note: I wish you guys stuck with the project name of "stan". And renamed this repo to go-stan and nats-streaming-server to stan-server

@pkieltyka
Copy link
Author

naming is very important in software. for some reason, NATS has many inconsistencies and breaks the rules and doesn't care to fix it for long periods of time.

@rybit
Copy link

rybit commented Oct 26, 2017

Agreed 100%

Also things like:

  • the stan.Subscription isn't a superset of the functionality of nats.Subscription
  • the go-nats-streaming package relies on the go-nats package, not the normal client lib

make the transition between the two very obnoxious. It is the case that I have a lot of code that uses/manages/creates nats connections already, and I have to go and update all of those just to change imports.

@tylertreat
Copy link
Contributor

@rybit

the go-nats-streaming package relies on the go-nats package, not the normal client lib

Not sure what you mean by that.

But yes, in general I agree it's confusing. NATS and NATS Streaming are entirely separate systems. We are going to work on clarifying that. Wally's recent ATO talk does a good job of presenting the difference I think: https://www.slideshare.net/wallyqs/nats-simple-secure-and-scalable-messaging-for-the-cloud-native-era-81170151

@rybit
Copy link

rybit commented Oct 26, 2017

I didn't realize that github.com/nats-io/nats -> github.com/nats-io/go-nats happened. I still have all my imports for the first one.

I will update my imports properly. Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants