Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - Docker Run Command Incorrect (Possibly) #243

Open
mmanna-sapfgl opened this issue Apr 18, 2019 · 1 comment
Open

Windows - Docker Run Command Incorrect (Possibly) #243

mmanna-sapfgl opened this issue Apr 18, 2019 · 1 comment
Assignees

Comments

@mmanna-sapfgl
Copy link

mmanna-sapfgl commented Apr 18, 2019

Whilst working on https://github.com/nats-io/go-nats-streaming/issues/242 and simple startup, I have observed this discrepancy.

in the documentation, it appears that nats-streaming-server command is added on docker run statement. However, i found out that this fails the startup. The following steps worked for me to successfully start nats-streaming container (same is true for NATS server.

docker run --rm -ti --name gnatsd-streamer -p 4223:4223 -p 8223:8223 -v /home/docker/streamer_conf.conf:/streamer_conf.conf -v /home/docker/streamer1:/streamer1 nats-streaming:latest -p 4223 -m 4223 -c /streamer_conf.conf

It started the NATS streaming server and I can also pub/sub to this. I believe the documentation for Windows Docker Image needs to be corrected here:

https://hub.docker.com/_/nats-streaming/

** What happens when I run with nats-streaming-server**

PS C:\Users\XXXX> docker run --rm -ti --name gnatsd-streamer -p 4223:4223 -p 8223:8223 nats-streaming:latest nats-streaming-server -p 4223 -m 8223
unrecognized command: "nats-streaming-server"
PS C:\Users\XXXX>

Could someone verify this?

Thanks,

@kozlovic
Copy link
Member

This should have been created on https://github.com/nats-io/nats-streaming-docker/issues.
As I explained yesterday on the other issue (see this comment), the absence of entry point (reason why it is not defined is explained in official-images PR) required the executable name to be passed to the docker run command if any additional parameter were needed.
It may be that your version of the docker server is more recent than mine and has solved that problem, but I still confirm that I need to specify nats-streaming-server in order to pass arguments. I may update the docker hub doc if I find which docker version is required to not have to pass the exe name.

Here is the screen capture of passing the -p 4223 argument without specifying the exe, followed by docker version:
DockerWindows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants