Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IPFabric matching of InterfaceTypes #414

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jmcgill298
Copy link
Contributor

Adds regex matching of interface names for when IPFabric does not provide a media_type.

@jmcgill298 jmcgill298 requested review from alhogan and a team as code owners April 3, 2024 15:03
@jmcgill298 jmcgill298 force-pushed the jacobm/ipfabric/interface-types branch 2 times, most recently from a2d458a to 2373f68 Compare April 3, 2024 15:08
@jmcgill298
Copy link
Contributor Author

jmcgill298 commented Apr 3, 2024

The failed test case is unrelated and fixed in #413 Rebased

Adds regex matching of interface names for when IPFabric does not
provide a media_type.
@jmcgill298 jmcgill298 force-pushed the jacobm/ipfabric/interface-types branch from 2373f68 to 00968b2 Compare April 4, 2024 13:48
Copy link

@alhogan-aa alhogan-aa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jmcgill298

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 6e2116e into develop Apr 16, 2024
18 checks passed
@jdrew82 jdrew82 deleted the jacobm/ipfabric/interface-types branch April 16, 2024 15:03
This was referenced Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants