unpins dependencies #418
Merged
unpins dependencies #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kircheneer
force-pushed
the
u/Kircheneer-unpin-dependencies
branch
from
938ac50
to
32f4efd
Compare
| @@ -50,7 +50,7 @@ pytz = { version = ">=2019.3", optional = true } | |||
| requests = { version = ">=2.21.0", optional = true } | |||
| requests-oauthlib = { version = ">=1.3.0", optional = true } | |||
| six = { version = ">=1.13.0", optional = true } | |||
| drf-spectacular = "0.26.3" | |||
| drf-spectacular = "^0.26.3" | |||
There was a problem hiding this comment.
Why does the app even need to care about the drf-spectacular version, given that it receives this dependency from nautobot core?
There was a problem hiding this comment.
Very good point, same should go for the prometheus_client honestly. I will review
There was a problem hiding this comment.
Can be probably reverted, don't remember exact reason other than there was a generic advice to use ^ in dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #417