Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itential SSoT #432

Merged
merged 38 commits into from
Jun 27, 2024
Merged

Itential SSoT #432

merged 38 commits into from
Jun 27, 2024

Conversation

jtdub
Copy link
Contributor

@jtdub jtdub commented Apr 17, 2024

This is a new integration for syncing inventory to Itential Automation Gateway.

It leverages External Integrations and Secrets for its primary configuration aspects as there can be any number of automation gateway servers deployed. Given the use of External Integrations, its minimum Nautobot version is 2.1.

@jtdub jtdub self-assigned this Apr 17, 2024
@jtdub jtdub requested a review from a team as a code owner April 17, 2024 21:30
@jtdub jtdub marked this pull request as draft April 17, 2024 21:30
@jtdub jtdub changed the title [WIP] Itential SSoT tential SSoT Apr 18, 2024
@jtdub jtdub marked this pull request as ready for review April 18, 2024 21:26
@jtdub jtdub changed the title tential SSoT Itential SSoT Apr 18, 2024
@jdrew82 jdrew82 added status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement New feature or request type: major feature labels Apr 19, 2024
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions and things to address.

nautobot_ssot/api/urls.py Outdated Show resolved Hide resolved
nautobot_ssot/tests/itential/test_jobs.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
nautobot_ssot/tests/itential/test_clients.py Outdated Show resolved Hide resolved
nautobot_ssot/tests/itential/test_diffsync.py Outdated Show resolved Hide resolved
nautobot_ssot/tests/itential/fixtures/logger.py Outdated Show resolved Hide resolved
@jdrew82
Copy link
Contributor

jdrew82 commented May 21, 2024

@jtdub Can you address the logger change that I mentioned and also rebase this so it's not conflicting anymore?

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, found a misspelling that needs to be corrected.

docs/admin/integrations/itential_setup.md Outdated Show resolved Hide resolved
@jdrew82
Copy link
Contributor

jdrew82 commented Jun 21, 2024

Actually, it appears you only have documentation in the admin section. Is there anything that should be documented in the User section?

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tweak but otherwise looks g2g.

docs/user/integrations/itential.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82
Copy link
Contributor

jdrew82 commented Jun 26, 2024

@jtdub can we get the tests fixed? It looks like we might have a migration conflict?

@jdrew82 jdrew82 added the integration: itential Issues/PRs for Itential integration label Jun 27, 2024
@jdrew82 jdrew82 added this to the 2.7.0 milestone Jun 27, 2024
@jdrew82 jdrew82 merged commit b4f1034 into nautobot:develop Jun 27, 2024
16 checks passed
@jtdub jtdub deleted the itential branch June 27, 2024 17:49
@jdrew82 jdrew82 mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: itential Issues/PRs for Itential integration status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement New feature or request type: major feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants