-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Itential SSoT #432
Itential SSoT #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions and things to address.
nautobot_ssot/integrations/itential/diffsync/models/nautobot.py
Outdated
Show resolved
Hide resolved
@jtdub Can you address the logger change that I mentioned and also rebase this so it's not conflicting anymore? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, found a misspelling that needs to be corrected.
Actually, it appears you only have documentation in the admin section. Is there anything that should be documented in the User section? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tweak but otherwise looks g2g.
Co-authored-by: Justin Drew <2396364+jdrew82@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jtdub can we get the tests fixed? It looks like we might have a migration conflict? |
This is a new integration for syncing inventory to Itential Automation Gateway.
It leverages External Integrations and Secrets for its primary configuration aspects as there can be any number of automation gateway servers deployed. Given the use of External Integrations, its minimum Nautobot version is 2.1.