Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing from Cloudvision - get_devices without the import_active argument #463

Closed
etiennelatulippe opened this issue May 30, 2024 · 1 comment · Fixed by #464
Closed
Labels
integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. type: bug Issues/PRs addressing a bug.

Comments

@etiennelatulippe
Copy link

etiennelatulippe commented May 30, 2024

Environment

  • Python version: 3.11
  • Nautobot version: 2.2.5
  • nautobot-ssot version: 2.6.1

What did you expect to happen?

Being able to sync from Cloudvision

What happened instead?

The job got an error using get_devices because it is called without the import_active argument.

{
"exc_message":[
"get_devices() missing 1 required argument: 'import_active'"
]
"exc_module": "builtins",
"exc_type": "TypeError"
}

https://github.com/nautobot/nautobot-app-ssot/blob/develop/nautobot_ssot/integrations/aristacv/diffsync/adapters/cloudvision.py#L72

https://github.com/nautobot/nautobot-app-ssot/blob/develop/nautobot_ssot/integrations/aristacv/utils/cloudvision.py#L256

Steps to Reproduce

  1. Go on the Cloudvision SSOT sync job
  2. Start the job
  3. Get the error
@etiennelatulippe etiennelatulippe changed the title Syncing from Cloudvision - get_devices without the import_active argument. Syncing from Cloudvision - get_devices without the import_active argument May 30, 2024
@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. labels May 30, 2024
@jdrew82 jdrew82 linked a pull request May 30, 2024 that will close this issue
@etiennelatulippe
Copy link
Author

The #464 is fixing the issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants