Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine Reasoning for Exception Handling in Example Job #521

Closed
jdrew82 opened this issue Aug 23, 2024 · 1 comment · Fixed by #534
Closed

Determine Reasoning for Exception Handling in Example Job #521

jdrew82 opened this issue Aug 23, 2024 · 1 comment · Fixed by #534
Assignees
@jdrew82
Labels
integration: contrib Contrib related issues and PRs status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation status: internal review Internal discussion is required to move forward with issue type: housekeeping

Comments

@jdrew82
Copy link
Contributor

jdrew82 commented Aug 23, 2024

Environment

  • Python version: 3.8
  • Nautobot version: 2.3.0
  • nautobot-ssot version: 3.0.0

It appears that there's a try/except block capturing all Exceptions in the DataSource Job here. We need to investigate to see why this is and most likely remove and change to only capture expected Exceptions and allow others to populate.
@jdrew82 jdrew82 added status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation status: internal review Internal discussion is required to move forward with issue type: housekeeping integration: contrib Contrib related issues and PRs labels Aug 23, 2024
@jdrew82 jdrew82 mentioned this issue Aug 23, 2024
Merged
@jdrew82 jdrew82 changed the title Determine Exception Handling in Example Job Determine Reasoning for Exception Handling in Example Job Aug 23, 2024
@Kircheneer
Copy link
Contributor

Looks like it should be nautobot.extras.exceptions.SecretError

@jdrew82 jdrew82 self-assigned this Sep 6, 2024
@jdrew82 jdrew82 mentioned this issue Sep 6, 2024
Merged
@jdrew82 jdrew82 linked a pull request Sep 6, 2024 that will close this issue
Fix Generalized Exceptions in Example Jobs #534
Merged
@jdrew82 jdrew82 mentioned this issue Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdrew82 jdrew82

Labels
integration: contrib Contrib related issues and PRs status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation status: internal review Internal discussion is required to move forward with issue type: housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Generalized Exceptions in Example Jobs nautobot/nautobot-app-ssot
2 participants
@jdrew82 @Kircheneer