External Integrations

[snaselj]

Closes: NaN

What's Changed

• Added external integration to example jobs.
• Added external integration to Arista Cloud Vision jobs.

[snaselj]

Added ExternalIntegration to AristaCV jobs. Could you pls. check it? @cmsirbu @jdrew82

[jdrew82]

Added ExternalIntegration to AristaCV jobs. Could you pls. check it? @cmsirbu @jdrew82

I looked at what you'd done and good idea with the config information but I'm not sure how that'd work for the configuration information though as that's technically static in most cases and without the ExternalIntegration being defined at time of Job run I'd be curious how it'd show data. Have you tested that bit?

[snaselj]

Added ExternalIntegration to AristaCV jobs. Could you pls. check it? @cmsirbu @jdrew82

I looked at what you'd done and good idea with the config information but I'm not sure how that'd work for the configuration information though as that's technically static in most cases and without the ExternalIntegration being defined at time of Job run I'd be curious how it'd show data. Have you tested that bit?

Without ExternalIntegration defined, this should work as before. If it's defined and specified as a job input argument, it takes precedence over PLUGIN_CONFIG values. Hope this is what was requested @cmsirbu

Have tested without real job run, just to create an integration, and call the job with it. It reads the data as expected. Would be great if someone with access to Arista CVP could test this.

[cmsirbu]

The general idea was to avoid making this a breaking change - which means that if someone upgrades to the next release of SSoT and uses the PLUGIN_CONFIG method, their setup will continue working without any change.

[jdrew82]

Added ExternalIntegration to AristaCV jobs. Could you pls. check it? @cmsirbu @jdrew82

I looked at what you'd done and good idea with the config information but I'm not sure how that'd work for the configuration information though as that's technically static in most cases and without the ExternalIntegration being defined at time of Job run I'd be curious how it'd show data. Have you tested that bit?

Without ExternalIntegration defined, this should work as before. If it's defined and specified as a job input argument, it takes precedence over PLUGIN_CONFIG values. Hope this is what was requested @cmsirbu

Have tested without real job run, just to create an integration, and call the job with it. It reads the data as expected. Would be great if someone with access to Arista CVP could test this.

I'm talking about the Config Information that shows on the DataSource/DataTarget pages. I'm pretty sure that's read at App load and isn't able to be dynamically updated by the ExternalIntegration selection.

[snaselj]

Added ExternalIntegration to AristaCV jobs. Could you pls. check it? @cmsirbu @jdrew82

I looked at what you'd done and good idea with the config information but I'm not sure how that'd work for the configuration information though as that's technically static in most cases and without the ExternalIntegration being defined at time of Job run I'd be curious how it'd show data. Have you tested that bit?

Without ExternalIntegration defined, this should work as before. If it's defined and specified as a job input argument, it takes precedence over PLUGIN_CONFIG values. Hope this is what was requested @cmsirbu
Have tested without real job run, just to create an integration, and call the job with it. It reads the data as expected. Would be great if someone with access to Arista CVP could test this.

I'm talking about the Config Information that shows on the DataSource/DataTarget pages. I'm pretty sure that's read at App load and isn't able to be dynamically updated by the ExternalIntegration selection.

I've refactored, how the configuration is gathered for CloudVision. There is a new optional key in PLUGIN_CONFIG["nautobot_ssot"]["aristacv_external_integration_name"] that can be used to specify integration to use.

[Kircheneer]

Can you provide an invoke command for the script you mentioned in your PR description? I think this would aid development in the future

[snaselj]

Can you provide an invoke command for the script you mentioned in your PR description? I think this would aid development in the future

Would rather do this in a separate PR not to block this one.

[jdrew82]

Few things to address but this looks good in general.

[jdrew82]

LGTM!