Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PROTECT to CASCADE for Sync #532

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented Sep 6, 2024

This PR closed out #528.

I also ran across a few other minor bugs that I fixed here when trying to create the migrations.

  • The _MIN_NAUTOBOT_VERSION check wasn't being done right and 2.1 wasn't working due to ACI requiring 2.2.
  • DNA Center was missing from list so I've added that.
  • I also had to adjust the logger in the Job dunder init because the utils file has a Controller import.

@jdrew82 jdrew82 added the type: bug Issues/PRs addressing a bug. label Sep 6, 2024
@jdrew82 jdrew82 self-assigned this Sep 6, 2024
@jdrew82 jdrew82 requested a review from a team as a code owner September 6, 2024 14:29
@jdrew82 jdrew82 linked an issue Sep 6, 2024 that may be closed by this pull request
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdrew82 jdrew82 merged commit fe534aa into develop Sep 6, 2024
14 checks passed
@jdrew82 jdrew82 deleted the 528-protect-method-breaks-new-log-cleanup-job branch September 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PROTECT Method Breaks New Log Cleanup Job
2 participants