Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nautobot SSoT: Slurpit #608

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

lpconsulting321
Copy link

Implements: #600

Added support for slurpit to sync locations, device types, devices, interfaces, inventory items, prefixes, vlans, vrf's and IP's.

Let me know if there are any issues.

@lpconsulting321 lpconsulting321 requested a review from a team as a code owner November 25, 2024 12:37
@jdrew82
Copy link
Contributor

jdrew82 commented Nov 25, 2024

@lpconsulting321 is this supposed to be in place of #601? Also, if so, can you rebase it so the conflicts are fixed?

@lpconsulting321
Copy link
Author

@jdrew82 Yes. I rebased and it messed everything up in the last branch. Will try to resolve now.

@lpconsulting321
Copy link
Author

@jdrew82 could you approve so tests can run. Hopefully they all pass now.

@jdrew82
Copy link
Contributor

jdrew82 commented Nov 28, 2024

My bad, didn't know it was waiting! Should be running now.

@lpconsulting321
Copy link
Author

@jdrew82 Failing test:
Locally I can replicate:

************* Module nautobot_ssot.contrib.model
nautobot_ssot/contrib/model.py:62:23: E1135: Value 'cls.model_fields' doesn't support membership test (unsupported-membership-test)

Using python 3.11 and Nautobot 2.2.1 which is what the test is failing on

However on python3.11 and Nautobot 2.3.1 it passes locally. Any idea what the issue could be?

@jdrew82
Copy link
Contributor

jdrew82 commented Nov 28, 2024

I saw this same exact error with another PR. If I remember right, it was Pydantic going up a version? Try to ensure that isn't changing by only adding in slurpit SDK and it should go away.

@lpconsulting321
Copy link
Author

@jdrew82 Fingers crossed. I have only updated lock file with slurpit sdk.

@lpconsulting321
Copy link
Author

Wheyy it all passed!

@jdrew82
Copy link
Contributor

jdrew82 commented Nov 29, 2024

Yeah, I'll try to give it a review this weekend if I have time but will most likely need to wait til I'm back in the office on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants