-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nautobot SSoT: Slurpit #608
base: develop
Are you sure you want to change the base?
Conversation
@lpconsulting321 is this supposed to be in place of #601? Also, if so, can you rebase it so the conflicts are fixed? |
@jdrew82 Yes. I rebased and it messed everything up in the last branch. Will try to resolve now. |
6f1fe53
to
f018623
Compare
@jdrew82 could you approve so tests can run. Hopefully they all pass now. |
My bad, didn't know it was waiting! Should be running now. |
@jdrew82 Failing test:
Using python 3.11 and Nautobot 2.2.1 which is what the test is failing on However on python3.11 and Nautobot 2.3.1 it passes locally. Any idea what the issue could be? |
I saw this same exact error with another PR. If I remember right, it was Pydantic going up a version? Try to ensure that isn't changing by only adding in slurpit SDK and it should go away. |
@jdrew82 Fingers crossed. I have only updated lock file with slurpit sdk. |
Wheyy it all passed! |
Yeah, I'll try to give it a review this weekend if I have time but will most likely need to wait til I'm back in the office on Monday. |
Implements: #600
Added support for slurpit to sync locations, device types, devices, interfaces, inventory items, prefixes, vlans, vrf's and IP's.
Let me know if there are any issues.