Fix index form does not update form value

guides/upgrading/v0.7.md

@@ -0,0 +1,23 @@
+# Upgrading to v0.7
+
+## Update calls to [`Backpex.Field.handle_index_editable/2`](Backpex.Field.html#handle_index_editable/3)
+
+We have updated the arity and syntax of [`Backpex.Field.handle_index_editable/2`](Backpex.Field.html#handle_index_editable/3). It is now [`Backpex.Field.handle_index_editable/3`](Backpex.Field.html#handle_index_editable/3) and accepts the `socket`, the `value` and the `change`. We now need the value to update the form accordingly.
+
+If you had code like this, e.g. for custom fields:
+
+```elixir
+@impl Phoenix.LiveComponent
+def handle_event("update-field", %{"index_form" => %{"value" => value}}, socket) do
+  Backpex.Field.handle_index_editable(socket, %{} |> Map.put(socket.assigns.name, value))
+end
+```
+
+it should now look like this
+
+```elixir
+@impl Phoenix.LiveComponent
+def handle_event("update-field", %{"index_form" => %{"value" => value}}, socket) do
+  Backpex.Field.handle_index_editable(socket, value, Map.put(%{}, socket.assigns.name, value))
+end
+```

lib/backpex/field.ex

@@ -238,7 +238,7 @@ defmodule Backpex.Field do
   @doc """
   Handles index editable.
   """
-  def handle_index_editable(socket, change) do
+  def handle_index_editable(socket, value, change) do
     if not Backpex.LiveResource.can?(socket.assigns, :edit, socket.assigns.item, socket.assigns.live_resource) do
       raise Backpex.ForbiddenError
     end
@@ -274,6 +274,7 @@ defmodule Backpex.Field do
         _error ->
           assign(socket, :valid, false)
       end
+      |> assign(:form, Phoenix.Component.to_form(%{"value" => value}, as: :index_form))
 
     {:noreply, socket}
   end

lib/backpex/fields/belongs_to.ex

@@ -132,8 +132,8 @@ defmodule Backpex.Fields.BelongsTo do
 
     assigns =
       assigns
-      |> assign(:form, form)
       |> assign(:options, options)
+      |> assign_new(:form, fn -> form end)
       |> assign_new(:valid, fn -> true end)
       |> assign_prompt(assigns.field_options)
 
@@ -155,7 +155,7 @@ defmodule Backpex.Fields.BelongsTo do
 
   @impl Phoenix.LiveComponent
   def handle_event("update-field", %{"index_form" => %{"value" => value}}, socket) do
-    Backpex.Field.handle_index_editable(socket, %{} |> Map.put(socket.assigns.owner_key, value))
+    Backpex.Field.handle_index_editable(socket, value, Map.put(%{}, socket.assigns.owner_key, value))
   end
 
   @impl Backpex.Field

lib/backpex/fields/date.ex

@@ -96,7 +96,7 @@ defmodule Backpex.Fields.Date do
 
     assigns =
       assigns
-      |> assign(:form, form)
+      |> assign_new(:form, fn -> form end)
       |> assign(:valid, Map.get(assigns, :valid, true))
 
     ~H"""
@@ -117,6 +117,6 @@ defmodule Backpex.Fields.Date do
 
   @impl Phoenix.LiveComponent
   def handle_event("update-field", %{"index_form" => %{"value" => value}}, socket) do
-    Backpex.Field.handle_index_editable(socket, %{} |> Map.put(socket.assigns.name, value))
+    Backpex.Field.handle_index_editable(socket, value, Map.put(%{}, socket.assigns.name, value))
   end
 end

lib/backpex/fields/date_time.ex

@@ -96,8 +96,8 @@ defmodule Backpex.Fields.DateTime do
 
     assigns =
       assigns
-      |> assign(:form, form)
       |> assign(:valid, Map.get(assigns, :valid, true))
+      |> assign_new(:form, fn -> form end)
 
     ~H"""
     <div>
@@ -117,6 +117,6 @@ defmodule Backpex.Fields.DateTime do
 
   @impl Phoenix.LiveComponent
   def handle_event("update-field", %{"index_form" => %{"value" => value}}, socket) do
-    Backpex.Field.handle_index_editable(socket, %{} |> Map.put(socket.assigns.name, value))
+    Backpex.Field.handle_index_editable(socket, value, Map.put(%{}, socket.assigns.name, value))
   end
 end

lib/backpex/fields/number.ex

@@ -55,7 +55,7 @@ defmodule Backpex.Fields.Number do
 
     assigns =
       assigns
-      |> assign(:form, form)
+      |> assign_new(:form, fn -> form end)
       |> assign_new(:valid, fn -> true end)
 
     ~H"""
@@ -76,7 +76,7 @@ defmodule Backpex.Fields.Number do
 
   @impl Phoenix.LiveComponent
   def handle_event("update-field", %{"index_form" => %{"index_input" => value}}, socket) do
-    Backpex.Field.handle_index_editable(socket, %{} |> Map.put(socket.assigns.name, value))
+    Backpex.Field.handle_index_editable(socket, value, Map.put(%{}, socket.assigns.name, value))
   end
 
   @impl Backpex.Field

lib/backpex/fields/select.ex

@@ -70,8 +70,8 @@ defmodule Backpex.Fields.Select do
 
     assigns =
       assigns
-      |> assign(:form, form)
       |> assign(:options, options)
+      |> assign_new(:form, fn -> form end)
       |> assign_new(:valid, fn -> true end)
       |> assign_prompt(assigns.field_options)
 
@@ -84,7 +84,7 @@ defmodule Backpex.Fields.Select do
           disabled={@readonly}
         >
           <option :if={@prompt} value=""><%= @prompt %></option>
-          <%= Phoenix.HTML.Form.options_for_select(@options, @value) %>
+          <%= Phoenix.HTML.Form.options_for_select(@options, @form[:value].value) %>
         </select>
       </.form>
     </div>
@@ -93,7 +93,7 @@ defmodule Backpex.Fields.Select do
 
   @impl Phoenix.LiveComponent
   def handle_event("update-field", %{"index_form" => %{"value" => value}}, socket) do
-    Backpex.Field.handle_index_editable(socket, %{} |> Map.put(socket.assigns.name, value))
+    Backpex.Field.handle_index_editable(socket, value, Map.put(%{}, socket.assigns.name, value))
   end
 
   defp get_label(value, options) do

lib/backpex/fields/text.ex

@@ -53,7 +53,7 @@ defmodule Backpex.Fields.Text do
 
     assigns =
       assigns
-      |> assign(:form, form)
+      |> assign_new(:form, fn -> form end)
       |> assign_new(:valid, fn -> true end)
 
     ~H"""
@@ -74,6 +74,6 @@ defmodule Backpex.Fields.Text do
 
   @impl Phoenix.LiveComponent
   def handle_event("update-field", %{"index_form" => %{"value" => value}}, socket) do
-    Backpex.Field.handle_index_editable(socket, %{} |> Map.put(socket.assigns.name, value))
+    Backpex.Field.handle_index_editable(socket, value, Map.put(%{}, socket.assigns.name, value))
   end
 end

mix.exs

@@ -143,6 +143,7 @@ defmodule Backpex.MixProject do
       "guides/custom_labels_and_translations/custom-labels-and-translations.md",
 
       # Upgrade Guides
+      "guides/upgrading/v0.7.md",
       "guides/upgrading/v0.6.md",
       "guides/upgrading/v0.5.md",
       "guides/upgrading/v0.3.md",