Better support for typing and mypy integration

[blazing-gig]

• fhir.resources version: 6.4.0
• Python version: 3.9
• Operating System: MacOS

Description

from fhir.resources.address import Address
from fhir.resources.patient import Patient

p = Patient.construct()

p.address.append(Address()) # -> This line gives an IDE type error which says it expects an instance of type `AddressType` instead. 

# With mypy the above line errors out

I'd like to understand the thought process behind why the type of Patient.address in the Pydantic base model has been annotated with typing.List[fhirtypes.AddressType] rather than the actual typing.List[fhirtypes.Address]. This would also help make the package compatible with mypy.

[blazing-gig]

@nazrulworld Would be happy to ideate and contribute if needed. Thanks

[nazrulworld]

@blazing-gig please have a look here #58

Any kind of contribution is always welcome 🙏

[blazing-gig]

Hey @nazrulworld I read through #58 and it seems by and large that this decision was made to circumvent circular deps while defining the models. Is this correct or am I missing something ?

[blazing-gig]

Hey @nazrulworld could you pls revert to my previous comment ? Coz if circular refs is the only problem, it can be annotated properly using this and made compatible with mypy. I can open a PR for the same if we can come to consensus on this. Thanks!

[imranq2]

Has this been fixed yet? It is super annoying to have mypy errors all over the place and we have to manually cast to get around them...